-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(detector-aws): remove all deprecation warnings #2642
fix(detector-aws): remove all deprecation warnings #2642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual code changes look good, but the package.json changes I think are not needed in this PR
detectors/node/opentelemetry-resource-detector-aws/package.json
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-aws/package.json
Outdated
Show resolved
Hide resolved
@dyladan Is it possible to review again? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2642 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 169 169
Lines 8061 8061
Branches 1646 1646
=======================================
Hits 7319 7319
Misses 742 742
|
ATTR_SERVICE_INSTANCE_ID, | ||
CLOUD_PROVIDER_VALUE_AWS, | ||
CLOUD_PLATFORM_VALUE_AWS_ELASTIC_BEANSTALK, | ||
} from '@opentelemetry/semantic-conventions/incubating'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't review this soon enough. We decided not to use incubating directly in runtime code.
https://github.com/open-telemetry/opentelemetry-js/tree/main/semantic-conventions#unstable-semconv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this to my attention. I've opened a new PR to address the issue: #2668
Which problem is this PR solving?
All experimental attributes were moved to
@opentelemetry/semantic-conventions/incubating
(see README) and the naming convention was changed, so there are currently dozens of deprecation being displayed for AWS Detectors.Short description of the changes
This PR updates all attributes for AWS Detectors to the new convention.