-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(instr-mysql2): Fix mysql2 instrumentation connection prototype #2578
Closed
david-luna
wants to merge
5
commits into
open-telemetry:main
from
david-luna:fix-mysql2-instrumentation-connection-prototype
Closed
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3f0eeaf
chore(instr-mysql2): update to mysql2@3.11.5
david-luna f715adf
fix(instr-mysql2): fix for mysql2@3.11.5
david-luna 5a51c55
fix(instr-mysql2): fix unwrap for mysql2@3.11.5
david-luna 2267454
chore(instr-mysql2): fix lint issues
david-luna b5b72ec
fix(instr-mysql2): fix how prototype is extracted
david-luna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think in older versions you get
EventEmitter
as a base. That may be why the TAV tests are failing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted the check to make it more explicit. It will return the base class prototype if it has the
query
function (execute
goes together). Otherwise it falls back to theConnection
prototype.Note: I had trouble running it locally since docker image
mysql:5.7
has no support forlinux/arm64/v8
platform. Is it possible to update the image version in@opentelemetry/contrib-test-utils
?