-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation-react-native-navigation): Adding new instrumentation library to track navigation changes for React Native apps #2359
base: main
Are you sure you want to change the base?
Conversation
|
7899a94
to
42ac15b
Compare
42ac15b
to
cc3c154
Compare
Fyi: still pending to submit the Instrumentation request that introduces this initiative. |
cc3c154
to
f71bc35
Compare
…ion library to track navigation for React Native apps
… for attributes + cleaning up tests
…adding comments + renaming spanCreator file
31f5acc
to
eea8205
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like this file was accidentally updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true. reverting. thanks for catching this
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2359 +/- ##
==========================================
+ Coverage 90.79% 90.85% +0.05%
==========================================
Files 169 176 +7
Lines 8061 8230 +169
Branches 1646 1681 +35
==========================================
+ Hits 7319 7477 +158
- Misses 742 753 +11
|
So @facostaembrace - do you need another maintainer here to get this reviewed? If so I volunteer to help maintain this with you. |
Hi @kndri ! I think I already have maintainers for this new package but all help is well received! Thanks for the interest!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd like to help keep this moving forward, and want to give you more leeway especially as this is 0.1.0 and it will be valuable to get feedback on how this works. This is the top requested feature in js-contrib.
@facostaembrace @jpmunz we'd like to add you to a triagers team and set a specific path in the CODEOWNERS path for you. We are working on this for other packages as well to ensure folks are pinged and assigned appropriately, as well as given the power to approve PRs (with the green check). To do this we need you to join the OpenTelemetry org.
I am working on some updated guidelines to add to the repo, but in the meantime please follow these guidelines in the community repo for member requirements.
@JamieDanielson I see in the Issue's template that I should mention two sponsors that "meet the sponsor requirements listed in the community membership guidelines". Am right assuming I can tag you + one person from the regular JS SIG meeting? (we can also discuss about this during tomorrow's meeting). Thanks! |
Which problem is this PR solving?
A couple of months ago, my team (Embrace) and I were looking for an instrumentation library that creates telemetry data for React Native applications. However, we noticed there was nothing available that adhered to open source standards. We also noticed people in Stack Overflow was asking about something similar.
This instrumentation library exposes two components that can be implemented at the root of React Native applications to create telemetry data that tracks navigation changes for the most popular navigation approaches in this environment.
Instrumentation request here.
#1089
Short description of the changes
<NativeNavigationTracker />
that creates spans and track navigation changes forwix/react-native-navigation
library, and<NavigationTracker />
that is meant to be used when the application handles the navigation using@react-navigation/native
orexpo-router
.