refactor(instr-redis-4): use exported strings for attributes #2100
+73
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2100 +/- ##
==========================================
- Coverage 90.97% 90.77% -0.21%
==========================================
Files 146 148 +2
Lines 7492 7675 +183
Branches 1502 1539 +37
==========================================
+ Hits 6816 6967 +151
- Misses 676 708 +32
|
maryliag
reviewed
Apr 15, 2024
| | ---------------------- | ---------------------------------------------------------------------------- | | ||
| | `db.statement` | The database statement being executed. | | ||
| | `db.system` | An identifier for the database management system (DBMS) product being used. | | ||
| | `db.connection_string` | The connection string used to connect to the database (without credentials). | |
There was a problem hiding this comment.
nit: can you move this up to keep this list ordered alphabetically?
59 tasks
maryliag
approved these changes
Apr 16, 2024
pichlermarc
approved these changes
Apr 17, 2024
maryliag
pushed a commit
to maryliag/opentelemetry-js-contrib
that referenced
this pull request
Apr 17, 2024
…lemetry#2100) * refactor(instr-redis-4): use exported strings for attributes * chore(instr-redis-4): update README --------- Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
SemanticAttributes.*with exported stringsSEMATTRS_*