Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(instr-undici): updates/tweaks for new undici instrumentation #2085

Merged
merged 9 commits into from
Apr 10, 2024
Merged

chore(instr-undici): updates/tweaks for new undici instrumentation #2085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
154b699
chore(instr-undici): updates/tweaks for new undici instrumentation
trentm Apr 4, 2024
7d06b0e
use tav 6.1.0 facility to reduce the number of test-all-versions ver …
trentm Apr 4, 2024
b42ad9f
skip this test case on old undici (< 5.12.0)
trentm Apr 4, 2024
2c3ce0c
option 1: min-supported undici version in 5.12.0
trentm Apr 5, 2024
50b0966
fix for undici@6.11.0 breakage, adapted from @david-luna patch in com…
trentm Apr 5, 2024
34b1f73
fix markdown lint
trentm Apr 5, 2024
54b11cb
make ts compile happy
trentm Apr 5, 2024
705b83d
revert this part of the change, because the relative links don't work…
trentm Apr 10, 2024
53d3f08
Merge branch 'main' into tm-instr-undici-follow-ups
trentm Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/component-label-map.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,10 @@ pkg:instrumentation-tedious:
- any-glob-to-any-file:
- plugins/node/instrumentation-tedious/**
- packages/opentelemetry-test-utils/**
pkg:instrumentation-undici:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I think we should merge this before we do a 1st release of this instrumentation

cc: @pichlermarc

- changed-files:
- any-glob-to-any-file:
- plugins/node/instrumentation-undici/**
pkg:instrumentation-user-interaction:
- changed-files:
- any-glob-to-any-file:
Expand Down
282 changes: 12 additions & 270 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions plugins/node/instrumentation-undici/.tav.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
undici:
jobs:
- versions: ">=5 <6"
- versions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is a good idea to reduce the number of versions

include: ">=5.12.0 <6"
mode: max-7
node: '>=14'
commands: npm run test
- versions: ">=6 <7"
- versions:
include: ">=6 <7"
mode: max-7
node: '>=18'
commands: npm run test
4 changes: 4 additions & 0 deletions plugins/node/instrumentation-undici/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ If you're looking the instrumentation for browser's `fetch` API it is located at
npm install --save @opentelemetry/instrumentation-undici
```

## Supported Versions

- `undici@>=5.12.0`

## Usage

OpenTelemetry Undici/fetch Instrumentation allows the user to automatically collect trace data and export them to their backend of choice, to give observability to distributed systems.
Expand Down
Loading
Loading