Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(resource-detector-github): update readme for github resource detector #2064

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Update README of GitHub Resource Detector to clarify the source of the data

@maryliag maryliag requested a review from a team March 28, 2024 16:29
@maryliag maryliag force-pushed the doc-github branch 3 times, most recently from e26c658 to 3efc3ff Compare March 29, 2024 15:48
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Merging #2064 (bf595ec) into main (dfb2dff) will decrease coverage by 0.34%.
Report is 46 commits behind head on main.
The diff coverage is n/a.

❗ Current head bf595ec differs from pull request most recent head b2d8b15. Consider uploading reports for the commit b2d8b15 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2064      +/-   ##
==========================================
- Coverage   90.97%   90.63%   -0.34%     
==========================================
  Files         146      146              
  Lines        7492     7488       -4     
  Branches     1502     1494       -8     
==========================================
- Hits         6816     6787      -29     
- Misses        676      701      +25     

see 8 files with indirect coverage changes

Update README of GitHub Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
@maryliag maryliag changed the title chore: update readme for github resource detector docs(resource-detector-github): update readme for github resource detector Apr 3, 2024
@trentm trentm enabled auto-merge (squash) April 9, 2024 23:58
@trentm trentm merged commit eaa99f8 into open-telemetry:main Apr 9, 2024
4 checks passed
@maryliag maryliag deleted the doc-github branch April 10, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants