-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(resource-detector-instana): use exported strings for attributes #2051
Conversation
Just a note, I recently updated the CONTRIBUTING doc because we no longer need to update the changelog on our own in PRs - it gets updated in the releasing step! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2051 +/- ##
==========================================
- Coverage 90.97% 90.82% -0.16%
==========================================
Files 146 148 +2
Lines 7492 7672 +180
Branches 1502 1537 +35
==========================================
+ Hits 6816 6968 +152
- Misses 676 704 +28
|
7c1d6b6
to
9c706ba
Compare
Updated to remove the changes on changelog |
ce62bc9
to
0b7a332
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one README nit.
@@ -31,7 +31,7 @@ import { NodeSDK } from "@opentelemetry/sdk-node"; | |||
import { instanaAgentDetector } from "@opentelemetry/resource-detector-instana"; | |||
|
|||
const globalResource = new Resource({ | |||
[SemanticResourceAttributes.SERVICE_NAME]: "TestService", | |||
[SEMRESATTRS_SERVICE_NAME]: "TestService", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps update the import { SemanticResourceAttributes } from "@opentelemetry/semantic-conventions";
a couple lines up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! Done
Use exported strings for Semantic Resource Attributes Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @maryliag ! Just a note, it's helpful for reviewers if you actually do not force-push changes, and instead keep the history. Not a big deal on smaller PRs, but as changes are made it can be difficult to see what's changed.
Which problem is this PR solving?
Short description of the changes
On package
opentelemetry-resource-detector-instana
:@opentelemetry/semantic-conventions
from^1.0.0
to^1.22.0