Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-dns): allow ignoreHostnames to be only a single IgnoreMatcher #1929

Merged
merged 3 commits into from
Feb 23, 2024
Merged

feat(instrumentation-dns): allow ignoreHostnames to be only a single IgnoreMatcher #1929

merged 3 commits into from
Feb 23, 2024

Conversation

10xLaCroixDrinker
Copy link
Contributor

Short description of the changes

This PR updates the ignoreHostnames option of @opentelemetry/instrumentation-dns to allow a single IgnoreMatcher rather than just an array of IgnoreMatcher.

@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team February 8, 2024 00:09
Copy link

linux-foundation-easycla bot commented Feb 8, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: pichlermarc / name: Marc Pichler (d889c87)
  • ✅ login: 10xLaCroixDrinker / name: Jamie King (97afbe6, 98d624c)

@blumamir
Copy link
Member

blumamir commented Feb 8, 2024

Thanks @10xLaCroixDrinker LGTM

Please sign the CLA so we can merge this PR

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Merging #1929 (97afbe6) into main (d0fc194) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 97afbe6 differs from pull request most recent head d889c87. Consider uploading reports for the commit d889c87 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1929   +/-   ##
=======================================
  Coverage   91.00%   91.00%           
=======================================
  Files         146      146           
  Lines        7491     7493    +2     
  Branches     1502     1503    +1     
=======================================
+ Hits         6817     6819    +2     
  Misses        674      674           
Files Coverage Δ
...ode/opentelemetry-instrumentation-dns/src/utils.ts 100.00% <100.00%> (ø)

@10xLaCroixDrinker
Copy link
Contributor Author

That's resolved now @blumamir

@pichlermarc pichlermarc merged commit a7861f6 into open-telemetry:main Feb 23, 2024
15 checks passed
@dyladan dyladan mentioned this pull request Feb 23, 2024
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/instrumentation-dns-single-ignorematcher branch February 28, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants