Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation-pg): remove @opentelemetry/core from dependencies #1895

Merged

Conversation

mothershipper
Copy link
Contributor

@mothershipper mothershipper commented Jan 12, 2024

Was introduced in commit a0003e76fc46afbbee2558a7d21906be7c9cb1d1 but all usages seem to have been removed.

By having this in the dependencies, we were getting peer-dep warnings on install as this version of core seems to be outdated.

Which problem is this PR solving?

  • When we run installs including the pg instrumentation, we get errors related to a peer-dep required by an old version of core, ex:
$ yarn install
warning "@opentelemetry/instrumentation-pg > @opentelemetry/core@1.8.0" has incorrect 
   peer dependency "@opentelemetry/api@>=1.0.0 <1.4.0".

Short description of the changes

Removes the dependency as the dep is no longer used within the package. This should clean up the warning.

Was introduced in commit `a0003e76fc46afbbee2558a7d21906be7c9cb1d1`
but all usages seem to have been removed.

By having this in the dependencies, we were getting peer-dep
warnings on install as this version of core seems to be outdated.
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Merging #1895 (aa277f5) into main (1e90a40) will increase coverage by 4.58%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1895      +/-   ##
==========================================
+ Coverage   91.47%   96.06%   +4.58%     
==========================================
  Files         145       14     -131     
  Lines        7423      914    -6509     
  Branches     1483      199    -1284     
==========================================
- Hits         6790      878    -5912     
+ Misses        633       36     -597     

see 131 files with indirect coverage changes

@blumamir blumamir merged commit c0d873c into open-telemetry:main Jan 13, 2024
17 checks passed
@dyladan dyladan mentioned this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants