Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency test-all-versions to v6 #1877

Merged

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Dec 22, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
test-all-versions 5.0.1 -> 6.0.0 age adoption passing confidence

Release Notes

watson/test-all-versions (test-all-versions)

v6.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team December 22, 2023 00:23
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Merging #1877 (d3e4aba) into main (ec7125b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1877   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files         144      144           
  Lines        7406     7406           
  Branches     1483     1483           
=======================================
  Hits         6773     6773           
  Misses        633      633           

@renovate-bot renovate-bot force-pushed the renovate/test-all-versions-6.x branch from 943ef51 to c2c1d71 Compare December 22, 2023 08:48
@pichlermarc
Copy link
Member

It's exiting with code 0 now if there are no versions. Other than everything seems non-breaking. package-lock.json seems fine. 🙂

@pichlermarc
Copy link
Member

Assigning a few labels for packages that use TAV to ensure it works as intended..

…ng an empty range

I also reduced the number of socket.io@4 versions tested (4.4.1 is over 2y old)
@trentm
Copy link
Contributor

trentm commented Dec 22, 2023

Assigning a few labels for packages that use TAV to ensure it works as intended..

Sigh. There is always something. test-all-versions@6.0.0 includes this breaking change: watson/test-all-versions@15bc19e
The commit message title is misleading, because it exits non-zero. So now tav is more strict about some ranges.

There is at least one case of this: socket.io

- versions: "^3.1.3"
peerDependencies: socket.io-client@^3
commands:
- npm run test

There is no socket.io@3.1.3 release.

Originally this was added because of this comment:
#1284 (review)
I'm a little confused how that table was generated, because AFAICT there never was a socket.io@3.1.3 release.

Fix pushed.

@trentm
Copy link
Contributor

trentm commented Dec 22, 2023

Running this from the repo root passed:

npm run --if-present --workspaces test-all-versions -- --dry-run --verbose

where as before it failed on instrumentation-socket.io's .tav.yml. So I believe that none of the other .tav.yml files will hit this new stricter tav behaviour.

🎵 All I want for xmas is for TAV to pass. 🎵

@trentm
Copy link
Contributor

trentm commented Dec 22, 2023

is for TAV to pass

Note that I still expect TAV to fail on redis-4 because: #1874

Copy link

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@trentm trentm merged commit 2d11b69 into open-telemetry:main Jan 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment