-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(host-metrics): bump minimum systeminformation version to 5.21.20 (security) #1868
Conversation
…n vulnerability in systeminformation Signed-off-by: yyomba <yyomba@salesforce.com>
Hi @yoanyomba2023 thanks for opening this PR and letting us know about this. While this is not exploitable in the way we use it in the A side note: please use GitHub's |
I took the liberty to sync the |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1868 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 144 144
Lines 7406 7406
Branches 1483 1483
=======================================
Hits 6773 6773
Misses 633 633 |
…(security) (open-telemetry#1868) * chore: bump system info version to address arbitrary command injection vulnerability in systeminformation Signed-off-by: yyomba <yyomba@salesforce.com> * chore: sync package-lock.json --------- Signed-off-by: yyomba <yyomba@salesforce.com> Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
hey @pichlermarc than you so much for the approval. On the module (host metrics) npm page, the version is still 0.34.0 which was released a month ago. Please reference: https://www.npmjs.com/package/@opentelemetry/host-metrics. I was wondering if the release failed by chance or didn't run? |
@yoanyomba2023 There just hasn't yet been a release of packages in this repo since this issue was merged two weeks ago. |
…n vulnerability in systeminformation
Which problem is this PR solving?
In the current version of the systeminformation library used by the host metrics package, a pretty serious vulnerability exists. That being the arbitrary command injection. This pull request addresss that by bumping the version of the library.
Short description of the changes
This changes is only comprised of a version bump.