Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: fix dual publish express #1859

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

Short description of the changes

WIP: attempting fix for dual-publishing CJS/ESM builds

@JamieDanielson JamieDanielson self-assigned this Dec 11, 2023
@github-actions github-actions bot requested a review from pkanal December 11, 2023 21:04
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #1859 (75023bb) into main (3cb2802) will decrease coverage by 3.69%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1859      +/-   ##
==========================================
- Coverage   91.45%   87.76%   -3.69%     
==========================================
  Files         144       30     -114     
  Lines        7406     1790    -5616     
  Branches     1483      388    -1095     
==========================================
- Hits         6773     1571    -5202     
+ Misses        633      219     -414     

see 114 files with indirect coverage changes

@blumamir
Copy link
Member

blumamir commented May 2, 2024

@JamieDanielson Wondering if this is still relevant and should be kept open.

@JamieDanielson
Copy link
Member Author

@JamieDanielson Wondering if this is still relevant and should be kept open.

I think this will be relevant and might be needed in all the packages... eventually. I guess the main question is to confirm whether this definitely works as expected and also determine the timeline to get these done. I've set it aside for now and will close as this can still be used as a guide even if closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants