Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(instrumentation-bunyan): update example dep now that there is a release with needed feature #1854

Merged
merged 3 commits into from
Dec 11, 2023
Merged

chore(instrumentation-bunyan): update example dep now that there is a release with needed feature #1854

merged 3 commits into from
Dec 11, 2023

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Dec 8, 2023

Closes: #1783

@trentm trentm self-assigned this Dec 8, 2023
@trentm trentm requested a review from a team December 8, 2023 18:39
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited
Loading

Codecov Report

Merging #1854 (8fe30df) into main (a8f3a3d) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head 8fe30df differs from pull request most recent head 34bbd2a. Consider uploading reports for the commit 34bbd2a to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1854   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files         144      144           
  Lines        7406     7406           
  Branches     1483     1483           
=======================================
  Hits         6773     6773           
  Misses        633      633

@trentm trentm enabled auto-merge (squash) December 11, 2023 22:14
@trentm trentm merged commit 60328af into open-telemetry:main Dec 11, 2023
3 checks passed
@trentm trentm deleted the tm-bunyan-example-dep-ver branch December 11, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees

@trentm trentm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[instrumentation-bunyan] update example dependency to use version instead of path
2 participants
@trentm @pichlermarc