test(instrumentation-aws-sdk): fix SQS mock responses for @aws-sdk/client-sqs versions using the AWS JSON 1.0 protocol #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient-sqs versions using the AWS JSON 1.0 protocol Versions 3.446.0 and later switched to a new JSON protocol. https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-sqs/CHANGELOG.md#34460-2023-11-08 Refs: open-telemetry#1838 (comment)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1844 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 144 144
Lines 7388 7388
Branches 1474 1474
=======================================
Hits 6760 6760
Misses 628 628 |
pichlermarc
approved these changes
Dec 6, 2023
trentm
added a commit
to trentm/opentelemetry-js-contrib
that referenced
this pull request
Dec 6, 2023
…ient-sqs versions using the AWS JSON 1.0 protocol (open-telemetry#1844) Versions 3.446.0 and later switched to a new JSON protocol. https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-sqs/CHANGELOG.md#34460-2023-11-08 Refs: open-telemetry#1838 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions 3.446.0 and later switched to a new JSON protocol.
https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-sqs/CHANGELOG.md#34460-2023-11-08
Refs: #1838 (comment)
Note that this fixes one issue with testing recent
@aws-sdk/client-sqsversions. TAV tests for aws-sdk will still fail for a different reason (#1477) until there is a workaround/fix for that.