Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): remove unused PR token in update package-lock step #1818

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Nov 22, 2023

Which problem is this PR solving?

The token in the update package-lock.json step is unused, we can remove it. It works fine with the regular workflow permissions.

@pichlermarc pichlermarc requested a review from a team November 22, 2023 09:15
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #1818 (47a9671) into main (a757b5e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1818   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files         143      143           
  Lines        7303     7303           
  Branches     1461     1461           
=======================================
  Hits         6677     6677           
  Misses        626      626           

@pichlermarc pichlermarc merged commit 71172e5 into open-telemetry:main Nov 22, 2023
13 checks passed
@pichlermarc pichlermarc deleted the fix/release-please-token branch November 22, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants