fix(instrumentation-aws-sdk): Add traceparent to AWS SDK unsignableHeaders #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
=======================================
Coverage 91.42% 91.43%
=======================================
Files 143 143
Lines 7303 7309 +6
Branches 1461 1465 +4
=======================================
+ Hits 6677 6683 +6
Misses 626 626
|
pichlermarc
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Looks good! I like this solution.
@blumamir would you mind also taking a look to ensure I'm not missing anything (I'm not too familiar with the aws sdk) 🙂
|
I mentioned a possible alternative fix at #1609 (comment) |
|
I think this can be closed now that #1609 is in. Update: The alternative fix was open-telemetry/opentelemetry-js#4346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This is an attempt to address the issue of a signature mismatch when a request fails and is retried. This happens because the instrumentation adds the
traceparentheader to outgoing headers. When a request fails, the value of the header changes, but the signature does not; and this results in an error.Fixes #1609 and open-telemetry/opentelemetry-js#3922
Short description of the changes
This change adds the
traceparentheader to the list of unsignable headers, so that it is excluded from creating the signature.