Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Export All Azure Resource Detectors #1800

Conversation

JacksonWeber
Copy link
Contributor

Which problem is this PR solving?

Azure resource detectors other than App Service are not being exported from index.

Short description of the changes

Export all azure resource detectors as currently only the app service detector is being exported.

@JacksonWeber JacksonWeber requested a review from a team November 16, 2023 04:32
@github-actions github-actions bot requested a review from hectorhdzg November 16, 2023 04:32
@JacksonWeber JacksonWeber changed the title Export all azure detectors. fix: Export All Azure Resource Detectors Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #1800 (e6c45a2) into main (c7c7547) will increase coverage by 0.42%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
+ Coverage   91.00%   91.42%   +0.42%     
==========================================
  Files         133      143      +10     
  Lines        6580     7303     +723     
  Branches     1311     1461     +150     
==========================================
+ Hits         5988     6677     +689     
- Misses        592      626      +34     

see 10 files with indirect coverage changes

@pichlermarc pichlermarc merged commit 7370386 into open-telemetry:main Nov 16, 2023
13 checks passed
@dyladan dyladan mentioned this pull request Nov 16, 2023
jmcdo29 pushed a commit to jmcdo29/opentelemetry-js-contrib that referenced this pull request Nov 21, 2023
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants