Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional instrumentation debug diagnostics #1777

Merged

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Nov 7, 2023

Which problem is this PR solving?

A few instrumentations were missing debug messages when patching was done, making it difficult to debug these in the wild.

Short description of the changes

Additionally I think graphql instrumentation was checking for the wrong method names when running unwrap (validate and parse), changed these to the correct ones.

@seemk seemk requested a review from a team November 7, 2023 10:32
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1777 (5d78dc6) into main (7348635) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1777   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files          14       14           
  Lines         914      914           
  Branches      199      199           
=======================================
  Hits          878      878           
  Misses         36       36           

@blumamir
Copy link
Member

blumamir commented Nov 7, 2023

I think in instrumentations we are trying to use this._diag where possible as it is a component logger that includes the instrumentation library name.

@seemk
Copy link
Contributor Author

seemk commented Nov 7, 2023

I think in instrumentations we are trying to use this._diag where possible as it is a component logger that includes the instrumentation library name.

Thanks, replaced the calls with this._diag.

@blumamir blumamir merged commit adbe86d into open-telemetry:main Nov 8, 2023
13 checks passed
@dyladan dyladan mentioned this pull request Nov 8, 2023
jmcdo29 pushed a commit to jmcdo29/opentelemetry-js-contrib that referenced this pull request Nov 13, 2023
* feat: additional instrumentation diagnostics

* fix: use componentlogger

---------

Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants