Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reconfigure stalebot to not close bugs #1709

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Stalebot seems to apply stale labels to bug issues and closing them. This PR addresses that by adding bug to the exempt-issue-labels.

@pichlermarc pichlermarc requested a review from a team October 2, 2023 12:42
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #1709 (b7040b7) into main (8ee01b6) will decrease coverage by 4.70%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1709      +/-   ##
==========================================
- Coverage   96.06%   91.36%   -4.70%     
==========================================
  Files          14      129     +115     
  Lines         914     6402    +5488     
  Branches      199     1281    +1082     
==========================================
+ Hits          878     5849    +4971     
- Misses         36      553     +517     

see 135 files with indirect coverage changes

@pichlermarc pichlermarc merged commit 2d36152 into open-telemetry:main Oct 5, 2023
@pichlermarc pichlermarc deleted the chore/stalebot-config branch October 5, 2023 05:54
@JamieDanielson
Copy link
Member

@pichlermarc I guess one idea to try (based on convo just had in SIG) - instead of having "exempt" labels to exempt bugs and instrumentation requests, we can have "any-of" labels, which is something we do on Honeycomb repos. This way we don't have to specifically remove a bug label if something is perhaps a misunderstanding but maybe a bug and needing info from the author.
So for example, our stalebot looks at any-of-labels: 'status: info needed,status: revision needed'

@pichlermarc
Copy link
Member Author

@pichlermarc I guess one idea to try (based on convo just had in SIG) - instead of having "exempt" labels to exempt bugs and instrumentation requests, we can have "any-of" labels, which is something we do on Honeycomb repos. This way we don't have to specifically remove a bug label if something is perhaps a misunderstanding but maybe a bug and needing info from the author. So for example, our stalebot looks at any-of-labels: 'status: info needed,status: revision needed'

Yep I think that's a good idea. 🙂 I've been meaning to introduce a few more that may lead to an issue being automatically closed for some time now as part of a new issue triage worflow. I think we can start with information-requested and gradually expand that as we add more labels.

Would you like to open a PR @JamieDanielson? Otherwise, I'll get around to it tomorrow. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants