Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency typescript to v5 #1522

Closed
wants to merge 1 commit into from
Closed

chore(deps): update dependency typescript to v5 #1522

wants to merge 1 commit into from

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented May 26, 2023 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
typescript (source) 4.4.4 -> 5.1.6 age adoption passing confidence

Release Notes

Microsoft/TypeScript (typescript)

v5.1.6: TypeScript 5.1.6

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on npm

v5.1.5: TypeScript 5.1.5

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.1.3: TypeScript 5.1.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.0.4: TypeScript 5.0.4

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.0.3: TypeScript 5.0.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.0.2: TypeScript 5.0

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v4.9.5: TypeScript 4.9.5

Compare Source

For release notes, check out the release announcement.

Downloads are available on:

Changes:

v4.9.4: TypeScript 4.9.4

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

Changes:

This list of changes was auto generated.

v4.9.3: TypeScript 4.9

Compare Source

For release notes, check out the release announcement.

Downloads are available on:

Changes:
See More

Configuration

📅 Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team May 26, 2023 00:44
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label May 26, 2023
@renovate-bot renovate-bot force-pushed the renovate/typescript-5.x branch from 1833b8e to c2ae9a3 Compare June 1, 2023 19:44
@renovate-bot renovate-bot force-pushed the renovate/typescript-5.x branch 4 times, most recently from 4a5e015 to 721acaa Compare June 29, 2023 00:32
@renovate-bot renovate-bot force-pushed the renovate/typescript-5.x branch 2 times, most recently from 9e41f6f to d300df1 Compare July 18, 2023 15:53
@renovate-bot renovate-bot force-pushed the renovate/typescript-5.x branch 3 times, most recently from d5c0f2b to bfb7c48 Compare August 2, 2023 14:19
@renovate-bot renovate-bot force-pushed the renovate/typescript-5.x branch from bfb7c48 to 0187f0c Compare August 6, 2023 09:30
@blumamir
Copy link
Member

@dyladan @Flarna - What should we do with this PR?

Is it considered a breaking change for our end users to update ts to a new major version?

@Flarna
Copy link
Member

Flarna commented Aug 10, 2023

If type definitions are part of the semver contract updating typescript is likely a breaking change and therefore semver major.

I fear it's just a matter of time until one of our dependencies/dev-dependencies come with types not working anymore with our already now 2 years old version.

I guess we should release major release more often. e.g. node.js has a major release very 6 month to allow breaking changes and to move forward. On the other hand they maintain also old branches for quite a while.

Or to formulate it in other words: OTel-JS requires a long term release plan

@blumamir
Copy link
Member

I fear it's just a matter of time until one of our dependencies/dev-dependencies come with types not working anymore with our already now 2 years old version.

#1563 already encounter issues around typescript 5, not sure if related.

I guess we should release major release more often. e.g. node.js has a major release very 6 month to allow breaking changes and to move forward. On the other hand they maintain also old branches for quite a while.

For this repo at least, the packages are all 0.x.y, so we can introduce breaking change with minor version bump.

I will bring up this issue in the next SIG to discuss.

@blumamir
Copy link
Member

As commented in this issue and discussed in SIG - upgrading to typescript 5 will be a breaking change for our current ts4 users.
It should be introduced in a new breaking change version.
Documented in OpenTelemetry SDK 2.0 Milestone

@blumamir blumamir closed this Aug 17, 2023
@forking-renovate
Copy link

forking-renovate bot commented Aug 17, 2023 •
edited
Loading

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 5.x releases. But if you manually upgrade to 5.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate-bot renovate-bot deleted the renovate/typescript-5.x branch August 17, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rauno56 rauno56

@dyladan dyladan

@vmarchaud vmarchaud

@legendecas legendecas

@blumamir blumamir

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@renovate-bot @blumamir @Flarna @rauno56 @dyladan @vmarchaud @legendecas