Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(host-metrics): update host metrics to collect metrics in batch #1450

Merged
merged 4 commits into from
Apr 6, 2023
Merged

feat(host-metrics): update host metrics to collect metrics in batch #1450

merged 4 commits into from
Apr 6, 2023

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

  • Host metrics now can be updated in batch rather than throttling the updates.

Short description of the changes

  • Use MeterProvider.addBatchObservableCallback.

@legendecas legendecas requested a review from a team March 30, 2023 08:35
@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited
Loading

Codecov Report

Merging #1450 (7047024) into main (fd5f87e) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
+ Coverage   96.13%   96.37%   +0.24%     
==========================================
  Files          14       19       +5     
  Lines         906     1049     +143     
  Branches      197      206       +9     
==========================================
+ Hits          871     1011     +140     
- Misses         35       38       +3
Impacted Files Coverage Δ
...ages/opentelemetry-host-metrics/src/BaseMetrics.ts 100.00% <ø> (ø)
packages/opentelemetry-host-metrics/src/metric.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

hectorhdzg
hectorhdzg approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas
Merge remote-tracking branch 'upstream/main' into host-metrics-batch
fabfc24 
# Conflicts:
#	packages/opentelemetry-host-metrics/src/metric.ts
@legendecas
Copy link
Member Author

Rebased and conflicts resolved.

@legendecas legendecas merged commit 6c708d1 into open-telemetry:main Apr 6, 2023
@legendecas legendecas deleted the host-metrics-batch branch April 6, 2023 06:01
@dyladan dyladan mentioned this pull request Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyladan dyladan dyladan approved these changes

@hectorhdzg hectorhdzg hectorhdzg approved these changes

Assignees

@legendecas legendecas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legendecas @dyladan @hectorhdzg @haddasbronfman