chore(mysql): remove mysql from dependencies #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flarna
approved these changes
Mar 29, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1445 +/- ##
==========================================
- Coverage 96.13% 95.93% -0.21%
==========================================
Files 14 18 +4
Lines 906 1181 +275
Branches 197 238 +41
==========================================
+ Hits 871 1133 +262
- Misses 35 48 +13
|
rauno56
approved these changes
Mar 30, 2023
pichlermarc
approved these changes
Mar 30, 2023
blumamir
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Remove unnecessary dependency on
mysqlpackage, which is only used in tests.Short description of the changes
Moved
mysqlto dev dependencies.