Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opentelemetry-sampler-aws-xray): add x-ray remote sampler #1443

Merged
merged 13 commits into from
May 11, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
201 changes: 201 additions & 0 deletions packages/opentelemetry-remote-sampler-aws-xray/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,201 @@
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

1. Definitions.

"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.

"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.

"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.

"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.

"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.

"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.

"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).

"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.

"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."

"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.

2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.

3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.

4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:

(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and

(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and

(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.

You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.

5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.

6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.

8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS

APPENDIX: How to apply the Apache License to your work.

To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [2022] OpenTelemetry Authors

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
1 change: 1 addition & 0 deletions packages/opentelemetry-remote-sampler-aws-xray/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# AWS X-Ray Remote Sampler
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
71 changes: 71 additions & 0 deletions packages/opentelemetry-remote-sampler-aws-xray/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
{
"name": "@opentelemetry/remote-sampler-aws-xray",
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
"version": "0.34.0",
"description": "OpenTelemetry remote sampler for AWS X-Ray",
"keywords": [
"aws",
"nodejs",
"opentelemetry"
],
"license": "Apache-2.0",
"author": "OpenTelemetry Authors",
"bugs": {
"url": "https://github.com/open-telemetry/opentelemetry-js-contrib/issues"
},
"main": "build/src/index.js",
"types": "build/src/index.d.ts",
"files": [
"build/src/**/*.js",
"build/src/**/*.js.map",
"build/src/**/*.d.ts",
"doc",
"LICENSE",
"README.md"
],
"repository": "open-telemetry/opentelemetry-js-contrib",
"scripts": {
"clean": "rimraf build/*",
"compile": "tsc -p .",
"lint": "eslint . --ext .ts",
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
"lint:fix": "eslint . --ext .ts --fix",
"precompile": "tsc --version && lerna run version:update --scope @opentelemetry/remote-sampler-aws-xray --include-dependencies",
"prewatch": "npm run precompile",
"prepare": "npm run compile",
"tdd": "npm run test -- --watch-extensions ts --watch",
"test": "nyc ts-mocha -p tsconfig.json --require '@opentelemetry/contrib-test-utils' 'test/**/*.test.ts'",
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
"test-all-versions": "tav",
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
"version:update": "node ../../scripts/version-update.js",
"watch": "tsc -w"
},
"peerDependencies": {
"@opentelemetry/api": "^1.3.0"
},
"dependencies": {
"@opentelemetry/core": "^1.8.0",
"@opentelemetry/instrumentation": "^0.35.1",
"@opentelemetry/semantic-conventions": "^1.0.0",
"@opentelemetry/propagation-utils": "^0.29.2"
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
},
"devDependencies": {
"@opentelemetry/api": "^1.3.0",
"@opentelemetry/contrib-test-utils": "^0.33.1",
"@opentelemetry/sdk-trace-base": "^1.8.0",
"@types/mocha": "8.2.3",
"@types/node": "18.11.7",
"@types/sinon": "10.0.6",
"eslint": "8.7.0",
"expect": "29.2.0",
"gts": "3.1.0",
"mocha": "7.2.0",
"nock": "13.2.1",
"nyc": "15.1.0",
"rimraf": "4.2.0",
"sinon": "15.0.1",
"test-all-versions": "5.0.1",
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
"ts-mocha": "10.0.0",
"typescript": "4.3.4"
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
},
"engines": {
"node": ">=14"
}
}
17 changes: 17 additions & 0 deletions packages/opentelemetry-remote-sampler-aws-xray/src/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/*
* Copyright The OpenTelemetry Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
export * from './remote-sampler';
export * from './remote-sampler.types';
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
/*
* Copyright The OpenTelemetry Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import { Sampler, SamplingDecision, SamplingResult } from '@opentelemetry/sdk-trace-base';
import { SamplingRule } from './remote-sampler.types';
import axios from 'axios';
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved

const DEFAULT_INTERVAL = 5 * 60 * 1000;// 5 minutes on sampling rules fetch (default polling interval)
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved


// IN PROGRESS - SKELETON CLASS
export class AWSXRayRemoteSampler implements Sampler {
private _pollingInterval: number;
private _endpoint: string;
private _samplingRulesEndpoint: string;
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved

constructor(endpoint: string, pollingInterval: number = DEFAULT_INTERVAL) {
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved

if (pollingInterval <= 0 || !Number.isInteger(pollingInterval)) {
throw new TypeError('pollingInterval must be a positive integer');
}
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved

this._pollingInterval = pollingInterval;
this._endpoint = endpoint;
this._samplingRulesEndpoint = "/GetSamplingRules";

// execute first get Sampling rules update using polling interval
this.getSamplingRules();
}

shouldSample(): SamplingResult {
// Implementation to be added
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a note to README saying this component is still in development. You can remove this note when the component is fully implemented

return { decision: SamplingDecision.NOT_RECORD };
}

toString(): string {
return `AWSXRayRemoteSampler`;
}

getEndpoint(): string {
return this._endpoint;
}

getPollingInterval(): number {
return this._pollingInterval;
}


// fetch sampling rules every polling interval
public async getSamplingRules(): Promise<void> {
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
const endpoint = this._endpoint + this._samplingRulesEndpoint;
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved

setInterval(async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This timer will live forever and prevent the application from stopping since it always has something to do.

You need to do either of the following:

clearInterval

use the clearInterval function to stop the interval when application goes down. I guess it will require adding shutdown() method to the sampler and for users to notify the object. Not sure about browser compatibility

unref

You can use the unref timer function to make sure the timer will never hold the event loop if nothing else needs it.

Not sure if you can unref an interval (or only timeout). You can switch to timeout implementation as well instead of interval if this is the case.

Anyway, no matter what you choose, please run a simple test to make sure application goes down nicely when sampler is in use

Copy link
Contributor Author

@carolabadeer carolabadeer Apr 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The x-ray remote sampler requires that the /GetSamplingRules endpoint is called every 5 minutes (or user-defined interval), and it is an essential component to ensuring the sampling behaves correctly. This behavior is implemented in a separate worker thread in our Go and DotNet implementations, but since JS is a single-threaded language it is preferred to use async calls through intervals or timeouts.

Our customer experience is centered around creating sampling rules in the X-Ray console, which will be fetched periodically using the /GetSamplingRules endpoint. If we want to stop the sampler, then the rules would be removed from the X-Ray console and the Sampler would be removed from the TracerProvider.

Please correct me if I misunderstood this part, but I believe that the snippet below from our documentation on initializing components to send traces to X-Ray would be used to make sure the application exits nicely.

// gracefully shut down the SDK on process exit
    process.on('SIGTERM', () => {
    sdk.shutdown()
      .then(() => console.log('Tracing and Metrics terminated'))
      .catch((error) => console.log('Error terminating tracing and metrics', error))
      .finally(() => process.exit(0));
    });

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I understand the need and support it, but I am just pointing out a problem with the current implementation that is not acceptable for end users.

The node application can terminate in a few ways:

Signal

In this case, I think the application will go down neither the less, and sdk.shutdown is more about exporting unsent spans from batch processors before terminating the application. please note that can still be nice to release acquired resources like timers but I don't think it's essential.

Please also not that sdk.shutdown() invokes tracerProvider.shutdown() which only calls shutdown on span processors. So the shutdown is important, but it will not trigger any cleanups on samplers.

No more events on event loop

As a simple toy example, consider this simple js application which is not doing too much:

console.log('hello world');

If we run this with node it prints and terminates immediately:

➜  node print-hello.js 
hello world
➜  

But if we had a setInterval in this code, it would now run forever:

setInterval(() => console.log('in interval'), 1000);

console.log('hello world');
➜  playground node print-hello.js
hello world
in interval
in interval
in interval
in interval
^C
➜  playground 

When you register a setInterval in user code, you are keeping the event loop busy forever which will alter the behavior of the some applications.

If you instead unref this timer, it would signal node that this timer should not hold the event loop alive if nothing else needs it:

const timer = setInterval(() => console.log('in interval'), 1000);
timer.unref();

console.log('hello world');
➜  playground node print-hello.js
hello world
➜  playground 

This practice is used in BatchSpanProcessorBase because of the above reasons, and in contrib repo here and here.

Basically, if you are a library that wishes to be transparent to the end-user and not have any side effects, you should unref every timer you set up.

The code above just prints to the console as an example, but any "script" that simply executes a js file with sequential commands until it reaches the end will now never complete, and the terminal will hang forever fetching the config endpoint.

const samplingRules: SamplingRule[] = []; // reset rules array
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved

const headers = {
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
headers: {
'Content-Type': 'application/json',
}
};

try {
const response = await axios.post(endpoint, null, headers);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can create a trace for this internal otel HTTP invocation. I guess most users don't care to record and pay for these spans, as they are not applicative spans. Similar to how we avoid recording exporter http calls.

You can suppress instrumentation for this call with the suppressTracing function. This repo has many examples on how to use it.

const responseJson = response.data;

responseJson?.SamplingRuleRecords.forEach((record: any) => {
Copy link
Member

@blumamir blumamir Apr 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it valid that responseJson is nullish (e.g. there is no data in response). Should we log something to diag in this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe if response is null then response.data will throw an error, which will lead to this warning being logged in the catch phrase:

diag.warn("Error fetching sampling rules: ", error);

if (record.SamplingRule) {
samplingRules.push(record.SamplingRule);
}
});
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
} catch (error) {
// Log error
console.log("Error fetching sampling rules: ", error);
carolabadeer marked this conversation as resolved.
Show resolved Hide resolved
}
}, this._pollingInterval);

}

}
Loading