Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup dead code for unsupported node versions #1391

Merged
merged 10 commits into from
Feb 13, 2023

Conversation

blumamir
Copy link
Member

This PR clean up some dead code related to node8 and node10 versions which is no longer supported

Minimum supported version for instrumentation is 14, as stated in package.json in each file

  "engines": {
    "node": ">=14"
  },

And there are no tests to verify any feature for older versions

@blumamir blumamir requested a review from a team February 12, 2023 13:43
@github-actions github-actions bot requested a review from rauno56 February 12, 2023 13:43
@blumamir blumamir changed the title Remove node 10 chore: cleanup dead code for unsupported node versions Feb 12, 2023
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #1391 (00b2088) into main (5a8df08) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
+ Coverage   96.10%   96.34%   +0.24%     
==========================================
  Files          14       20       +6     
  Lines         898     1123     +225     
  Branches      192      218      +26     
==========================================
+ Hits          863     1082     +219     
- Misses         35       41       +6     
Impacted Files Coverage Δ
...ry-instrumentation-dns/src/enums/AttributeNames.ts 100.00% <ø> (ø)
...resource-detector-gcp/src/detectors/GcpDetector.ts 96.00% <100.00%> (ø)
...lemetry-instrumentation-dns/src/instrumentation.ts 95.65% <100.00%> (ø)
...ode/opentelemetry-instrumentation-dns/src/utils.ts 100.00% <100.00%> (ø)
...metry-resource-detector-gcp/src/detectors/index.ts 100.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 98.21% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants