fix(instrumentation/aws-lambda): Ensure callback is only called once #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…regardless how many providers are flushed Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1384 +/- ##
==========================================
- Coverage 96.10% 95.87% -0.23%
==========================================
Files 14 16 +2
Lines 898 1116 +218
Branches 192 233 +41
==========================================
+ Hits 863 1070 +207
- Misses 35 46 +11
|
pichlermarc
approved these changes
Feb 8, 2023
dyladan
approved these changes
Feb 8, 2023
plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
…rumentation.ts Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
legendecas
approved these changes
Feb 8, 2023
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…regardless how many providers are flushed
Signed-off-by: Anthony J Mirabella a9@aneurysm9.com
Which problem is this PR solving?
Defect identified in #1370 (review).
Short description of the changes
Combine all provider flush invocations to a single
Promise.all()that can be resolved once.