Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hapi): don't patch unsupported hapi version 21 #1382

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

blumamir
Copy link
Member

@blumamir blumamir commented Feb 8, 2023

Renovate opened a PR for new hapi version 21 here. The Ci failed and there are few issues with this new version

Since instrumentation doesn't work well with this new version, I removed it from the patch definition so it will not break users

The README is already updated with the correct supported versions range

@blumamir blumamir requested a review from a team February 8, 2023 12:27
@blumamir blumamir mentioned this pull request Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #1382 (bb349c4) into main (ae6d4f3) will increase coverage by 0.66%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1382      +/-   ##
==========================================
+ Coverage   96.10%   96.77%   +0.66%     
==========================================
  Files          14       19       +5     
  Lines         898     1146     +248     
  Branches      192      228      +36     
==========================================
+ Hits          863     1109     +246     
- Misses         35       37       +2     
Impacted Files Coverage Δ
...emetry-instrumentation-hapi/src/instrumentation.ts 99.31% <ø> (ø)
...lemetry-instrumentation-hapi/src/internal-types.ts 100.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 98.21% <0.00%> (ø)
...y-instrumentation-hapi/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...de/opentelemetry-instrumentation-hapi/src/utils.ts 100.00% <0.00%> (ø)

@blumamir blumamir merged commit 61255e2 into open-telemetry:main Feb 15, 2023
Abinet18 pushed a commit to Abinet18/opentelemetry-js-contrib that referenced this pull request Feb 25, 2023
Co-authored-by: Haddas Bronfman <85441461+haddasbronfman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants