chore: move release-please action run #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1380 +/- ##
=======================================
Coverage 96.10% 96.10%
=======================================
Files 14 14
Lines 898 898
Branches 192 192
=======================================
Hits 863 863
Misses 35 35 |
dyladan
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Looking at https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/4118780372/jobs/7111714212, the comments were posted to the PR almost 40 minutes before the packages were even built, not to mention when they were actually published
Short description of the changes
Moves the action posting comments to after the packages are built, in order for there to be less time between a comment saying "the update is published" and it actually being true.