-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(instrumentation-dns): fix instrumentation of dns/promises
#1377
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1377 +/- ##
==========================================
- Coverage 96.10% 95.47% -0.64%
==========================================
Files 14 18 +4
Lines 898 1082 +184
Branches 192 217 +25
==========================================
+ Hits 863 1033 +170
- Misses 35 49 +14
|
This reverts commit a897248.
...s/node/opentelemetry-instrumentation-dns/test/integrations/dns-slash-promises-lookup.test.ts
Show resolved
Hide resolved
BTW, the PR description mentions that currently, we get a "no original function lookup to wrap" warning. Why is that? |
You're right, that's incorrect. That warning was happening on an old version ( |
Which problem is this PR solving?
This PR fixes
@opentelemetry/instrumentation-dns
when used withdns/promises
.Short description of the changes
This PR adds logic to
@opentelemetry/instrumentation-dns
that instrumentsdns/promises
. This will properly instrumentlookup
when it comes fromdns/promises
; currently, that instrumentation is not happening.