feat(detector-gcp): collect hostname resource attribute from GCP Metadata API #1364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR is mostly for convenience. When working on collecting host-id for non-cloud environments, I was looking at the AWS EC2 Detector and the GCP Detector. I noticed that the EC2 Detector collects both host.name and
host.id
, and the GCP Detector collects onlyhost.id
. I updated the GCP Detector to collect host.name for congruence with the EC2 Detector and also so that GCP users will not have to use the Host Detector, or worry about Detector ordering when collecinghost.name
andhost.id
.Short description of the changes
host.name
resource attribute in GCP Detector