Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix instrumentation-fs tests on windows #1010

Merged
merged 1 commit into from
May 6, 2022

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented May 6, 2022

Which problem is this PR solving?

Short description of the changes

Removed \n in test to avoid OS and .gitattributes dependencies.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

removed \n in test to avoid OS and .gitattributes dependencies.
@Flarna Flarna requested a review from a team May 6, 2022 08:55
@github-actions github-actions bot requested a review from rauno56 May 6, 2022 08:56
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1010 (960df39) into main (c7b586f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1010   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          13       13           
  Lines         856      856           
  Branches      178      178           
=======================================
  Hits          821      821           
  Misses         35       35           

Copy link
Member

@rauno56 rauno56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Flarna Flarna added the tests label May 6, 2022
@rauno56 rauno56 merged commit 61ead95 into open-telemetry:main May 6, 2022
@Flarna Flarna deleted the fix-fs-win branch May 6, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants