-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fastify's _patchConstructor causing errorCodes to be inaccessible #2027
Comments
tsmithhisler
added a commit
to tsmithhisler/opentelemetry-js-contrib
that referenced
this issue
Jan 8, 2025
fastify v4.x+ exports an object named `errorCodes` as both a property of the default export and as a named export. The export is documented at https://github.com/fastify/fastify/blob/4.x/docs/Reference/Errors.md?plain=1#L236. This closes open-telemetry#2027.
tsmithhisler
added a commit
to tsmithhisler/opentelemetry-js-contrib
that referenced
this issue
Jan 8, 2025
fastify v4.x+ exports an object named `errorCodes` as both a property of the default export and as a named export. The export is documented at https://github.com/fastify/fastify/blob/4.x/docs/Reference/Errors.md?plain=1#L236. This closes open-telemetry#2027.
tsmithhisler
added a commit
to tsmithhisler/opentelemetry-js-contrib
that referenced
this issue
Jan 8, 2025
fastify v4.x+ exports an object named `errorCodes` as both a property of the default export and as a named export. The export is documented at https://github.com/fastify/fastify/blob/4.x/docs/Reference/Errors.md?plain=1#L236. This closes open-telemetry#2027.
tsmithhisler
added a commit
to tsmithhisler/opentelemetry-js-contrib
that referenced
this issue
Jan 9, 2025
fastify v4.x+ exports an object named `errorCodes` as both a property of the default export and as a named export. The export is documented at https://github.com/fastify/fastify/blob/4.x/docs/Reference/Errors.md?plain=1#L236. This closes open-telemetry#2027.
tsmithhisler
added a commit
to tsmithhisler/opentelemetry-js-contrib
that referenced
this issue
Jan 9, 2025
fastify v4.8+ exports an object named `errorCodes` as both a property of the default export and as a named export. The export is documented at https://github.com/fastify/fastify/blob/4.x/docs/Reference/Errors.md?plain=1#L236. This closes open-telemetry#2027.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts
Lines 203 to 222 in 9df30ea
This overrides the originally exported
fastify
while it should containerrorCodes
as assigned here. This breaks whenever I try to do this:The
errorCodes
is alwaysundefined
.Is there any workaround for this?
The text was updated successfully, but these errors were encountered: