fix(perf_hooks): don't export when disabled

open-telemetry · Jan 16, 2024 · e8e81a7 · e8e81a7
1 parent 0ecc3e4
commit e8e81a7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/plugins/node/instrumentation-perf-hooks/src/instrumentation.ts b/plugins/node/instrumentation-perf-hooks/src/instrumentation.ts
@@ -82,6 +82,7 @@ export class PerfHooksInstrumentation extends InstrumentationBase {
   }
 
   override disable() {
+    this._clearELU();
     clearInterval(this._interval);
     this._interval = undefined;
   }

diff --git a/plugins/node/instrumentation-perf-hooks/test/event_loop_utilization.test.ts b/plugins/node/instrumentation-perf-hooks/test/event_loop_utilization.test.ts
@@ -86,4 +86,12 @@ describe('nodejs.performance.event_loop.utilization', () => {
     );
     assert.strictEqual(metrics[0].descriptor.unit, '1');
   });
+
+  it('should stop exporting metrics when disabled', async () => {
+    instrumentation.disable();
+    await new Promise(resolve => setTimeout(resolve, EXPORT_INTERVAL));
+    const resourceMetrics = metricExporter.getMetrics();
+    const scopeMetrics = resourceMetrics[0].scopeMetrics;
+    assert.strictEqual(scopeMetrics.length, 0);
+  });
 });