fix(net.peer.port): net.peer.port needs to be a number not a string

Signed-off-by: esara <endresara@gmail.com>
open-telemetry · Jan 28, 2024 · e4170d0 · e4170d0
1 parent 12834d5
commit e4170d0
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 12 deletions.
diff --git a/plugins/node/opentelemetry-instrumentation-memcached/src/utils.ts b/plugins/node/opentelemetry-instrumentation-memcached/src/utils.ts
@@ -45,10 +45,18 @@ export const getPeerAttributes = (
 
   if (typeof server === 'string') {
     const [host, port] = server && server.split(':');
-    return {
-      [SemanticAttributes.NET_PEER_NAME]: host,
-      [SemanticAttributes.NET_PEER_PORT]: port,
-    };
+    if (host && port) {
+      const portNumber = parseInt(port, 10);
+      if (!isNaN(portNumber)) {
+        return {
+          [SemanticAttributes.NET_PEER_NAME]: host,
+          [SemanticAttributes.NET_PEER_PORT]: portNumber,
+        };
+      }
+      return {
+        [SemanticAttributes.NET_PEER_NAME]: host,
+      };
+    }
   }
   return {};
 };
diff --git a/plugins/node/opentelemetry-instrumentation-mongodb/src/instrumentation.ts b/plugins/node/opentelemetry-instrumentation-mongodb/src/instrumentation.ts
@@ -813,10 +813,11 @@ export class MongoDBInstrumentation extends InstrumentationBase {
     });
 
     if (host && port) {
-      span.setAttributes({
-        [SemanticAttributes.NET_PEER_NAME]: host,
-        [SemanticAttributes.NET_PEER_PORT]: port,
-      });
+      span.setAttribute(SemanticAttributes.NET_PEER_NAME, host);
+      const portNumber = parseInt(port, 10);
+      if (!isNaN(portNumber)) {
+        span.setAttribute(SemanticAttributes.NET_PEER_PORT, portNumber);
+      }
     }
     if (!commandObj) return;
     const dbStatementSerializer =

diff --git a/plugins/node/opentelemetry-instrumentation-mysql/src/utils.ts b/plugins/node/opentelemetry-instrumentation-mysql/src/utils.ts
@@ -33,10 +33,22 @@ export function getConnectionAttributes(
   config: ConnectionConfig | PoolActualConfig
 ): SpanAttributes {
   const { host, port, database, user } = getConfig(config);
-
+  const portNumber = parseInt(port, 10);
+  if (!isNaN(portNumber)) {
+    return {
+      [SemanticAttributes.NET_PEER_NAME]: host,
+      [SemanticAttributes.NET_PEER_PORT]: portNumber,
+      [SemanticAttributes.DB_CONNECTION_STRING]: getJDBCString(
+        host,
+        port,
+        database
+      ),
+      [SemanticAttributes.DB_NAME]: database,
+      [SemanticAttributes.DB_USER]: user,
+    };
+  }
   return {
     [SemanticAttributes.NET_PEER_NAME]: host,
-    [SemanticAttributes.NET_PEER_PORT]: port,
     [SemanticAttributes.DB_CONNECTION_STRING]: getJDBCString(
       host,
       port,

diff --git a/plugins/node/opentelemetry-instrumentation-mysql2/src/utils.ts b/plugins/node/opentelemetry-instrumentation-mysql2/src/utils.ts
@@ -48,10 +48,22 @@ interface Config {
  */
 export function getConnectionAttributes(config: Config): SpanAttributes {
   const { host, port, database, user } = getConfig(config);
-
+  const portNumber = parseInt(port, 10);
+  if (!isNaN(portNumber)) {
+    return {
+      [SemanticAttributes.NET_PEER_NAME]: host,
+      [SemanticAttributes.NET_PEER_PORT]: portNumber,
+      [SemanticAttributes.DB_CONNECTION_STRING]: getJDBCString(
+        host,
+        port,
+        database
+      ),
+      [SemanticAttributes.DB_NAME]: database,
+      [SemanticAttributes.DB_USER]: user,
+    };
+  }
   return {
     [SemanticAttributes.NET_PEER_NAME]: host,
-    [SemanticAttributes.NET_PEER_PORT]: port,
     [SemanticAttributes.DB_CONNECTION_STRING]: getJDBCString(
       host,
       port,