-
Notifications
You must be signed in to change notification settings - Fork 544
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(aws-lambda): BasicTracerProvider not force flushing (#661)
Co-authored-by: William Armiros <54150514+willarmiros@users.noreply.github.com> Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
- Loading branch information
3 people
authored
Sep 21, 2021
1 parent
7edf984
commit 76e0d0f
Showing
3 changed files
with
160 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
128 changes: 128 additions & 0 deletions
128
...telemetry-instrumentation-aws-lambda/test/integrations/lambda-handler.force-flush.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| // We access through node_modules to allow it to be patched. | ||
| /* eslint-disable node/no-extraneous-require */ | ||
|
|
||
| import * as path from 'path'; | ||
|
|
||
| import { AwsLambdaInstrumentation } from '../../src'; | ||
| import { | ||
| BatchSpanProcessor, | ||
| InMemorySpanExporter, | ||
| } from '@opentelemetry/tracing'; | ||
| import { NodeTracerProvider } from '@opentelemetry/node'; | ||
| import { Context } from 'aws-lambda'; | ||
| import * as assert from 'assert'; | ||
| import { ProxyTracerProvider, TracerProvider } from '@opentelemetry/api'; | ||
|
|
||
| const memoryExporter = new InMemorySpanExporter(); | ||
|
|
||
| describe('force flush', () => { | ||
| let instrumentation: AwsLambdaInstrumentation; | ||
|
|
||
| let oldEnv: NodeJS.ProcessEnv; | ||
|
|
||
| const ctx = { | ||
| functionName: 'my_function', | ||
| invokedFunctionArn: 'my_arn', | ||
| awsRequestId: 'aws_request_id', | ||
| } as Context; | ||
|
|
||
| const initializeHandler = (handler: string, provider: TracerProvider) => { | ||
| process.env._HANDLER = handler; | ||
|
|
||
| instrumentation = new AwsLambdaInstrumentation(); | ||
| instrumentation.setTracerProvider(provider); | ||
| }; | ||
|
|
||
| const lambdaRequire = (module: string) => | ||
| require(path.resolve(__dirname, '..', module)); | ||
|
|
||
| beforeEach(() => { | ||
| oldEnv = { ...process.env }; | ||
| process.env.LAMBDA_TASK_ROOT = path.resolve(__dirname, '..'); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| process.env = oldEnv; | ||
| instrumentation.disable(); | ||
|
|
||
| memoryExporter.reset(); | ||
| }); | ||
|
|
||
| it('should force flush NodeTracerProvider', async () => { | ||
| const provider = new NodeTracerProvider(); | ||
| provider.addSpanProcessor(new BatchSpanProcessor(memoryExporter)); | ||
| provider.register(); | ||
| let forceFlushed = false; | ||
| const forceFlush = () => | ||
| new Promise<void>(resolve => { | ||
| forceFlushed = true; | ||
| resolve(); | ||
| }); | ||
| provider.activeSpanProcessor.forceFlush = forceFlush; | ||
| initializeHandler('lambda-test/sync.handler', provider); | ||
|
|
||
| await new Promise((resolve, reject) => { | ||
| lambdaRequire('lambda-test/sync').handler( | ||
| 'arg', | ||
| ctx, | ||
| (err: Error, res: any) => { | ||
| if (err) { | ||
| reject(err); | ||
| } else { | ||
| resolve(res); | ||
| } | ||
| } | ||
| ); | ||
| }); | ||
|
|
||
| assert.strictEqual(forceFlushed, true); | ||
| }); | ||
|
|
||
| it('should force flush ProxyTracerProvider with NodeTracerProvider', async () => { | ||
| const nodeTracerProvider = new NodeTracerProvider(); | ||
| nodeTracerProvider.addSpanProcessor(new BatchSpanProcessor(memoryExporter)); | ||
| nodeTracerProvider.register(); | ||
| const provider = new ProxyTracerProvider(); | ||
| provider.setDelegate(nodeTracerProvider); | ||
| let forceFlushed = false; | ||
| const forceFlush = () => | ||
| new Promise<void>(resolve => { | ||
| forceFlushed = true; | ||
| resolve(); | ||
| }); | ||
| nodeTracerProvider.activeSpanProcessor.forceFlush = forceFlush; | ||
| initializeHandler('lambda-test/sync.handler', provider); | ||
|
|
||
| await new Promise((resolve, reject) => { | ||
| lambdaRequire('lambda-test/sync').handler( | ||
| 'arg', | ||
| ctx, | ||
| (err: Error, res: any) => { | ||
| if (err) { | ||
| reject(err); | ||
| } else { | ||
| resolve(res); | ||
| } | ||
| } | ||
| ); | ||
| }); | ||
|
|
||
| assert.strictEqual(forceFlushed, true); | ||
| }); | ||
| }); |