feat(cucumber): support @cucumber/cucumber@10 (#1830)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
open-telemetry · Dec 1, 2023 · 1c2e8b2 · 1c2e8b2
1 parent 4ca1862
commit 1c2e8b2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/plugins/node/instrumentation-cucumber/.tav.yml b/plugins/node/instrumentation-cucumber/.tav.yml
@@ -1,3 +1,7 @@
 '@cucumber/cucumber':
-  versions: '^8.0.0 || ^9.0.0'
-  commands: npm test
+  - versions: '^8.0.0 || ^9.0.0'
+    node: '>=14'
+    commands: npm test
+  - versions: '^10.0.0'
+    node: '>=18'
+    commands: npm test
diff --git a/plugins/node/instrumentation-cucumber/src/instrumentation.ts b/plugins/node/instrumentation-cucumber/src/instrumentation.ts
@@ -52,7 +52,7 @@ export class CucumberInstrumentation extends InstrumentationBase {
     return [
       new InstrumentationNodeModuleDefinition<Cucumber>(
         '@cucumber/cucumber',
-        ['^8.0.0', '^9.0.0'],
+        ['^8.0.0', '^9.0.0', '^10.0.0'],
         (moduleExports, moduleVersion) => {
           this._diag.debug(
             `Applying patch for @cucumber/cucumber@${moduleVersion}`
@@ -86,7 +86,7 @@ export class CucumberInstrumentation extends InstrumentationBase {
             default: { new (): TestCaseRunner; prototype: TestCaseRunner };
           }>(
             '@cucumber/cucumber/lib/runtime/test_case_runner.js',
-            ['^8.0.0', '^9.0.0'],
+            ['^8.0.0', '^9.0.0', '^10.0.0'],
             (moduleExports, moduleVersion) => {
               this._diag.debug(
                 `Applying patch for @cucumber/cucumber/lib/runtime/test_case_runner.js@${moduleVersion}`