fix compile

open-telemetry · Nov 7, 2023 · 18832b4 · 18832b4
1 parent b009011
commit 18832b4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/plugins/node/opentelemetry-instrumentation-fastify/package.json b/plugins/node/opentelemetry-instrumentation-fastify/package.json
@@ -56,6 +56,7 @@
     "@types/express": "4.17.18",
     "@types/mocha": "7.0.2",
     "@types/node": "18.15.3",
+    "@types/semver": "7.5.5",
     "fastify": "4.18.0",
     "mocha": "7.2.0",
     "nyc": "15.1.0",

diff --git a/plugins/node/opentelemetry-instrumentation-fastify/test/instrumentation.test.ts b/plugins/node/opentelemetry-instrumentation-fastify/test/instrumentation.test.ts
@@ -449,14 +449,13 @@ describe('fastify', () => {
         // 'preClose' was added in fastify@4.16.0
         if (semver.lt(fastifyVersion, '4.16.0')) {
           this.skip();
-          return;
-        }
-
-        app.addHook('preClose', () => {
-          assertRootContextActive();
-        });
+        } else {
+          app.addHook('preClose', () => {
+            assertRootContextActive();
+          });
 
-        await startServer();
+          await startServer();
+        }
       });
 
       it('onClose is not instrumented', async () => {