Skip to content

Commit

Permalink
Merge branch 'main' into dluna/knex-semconv-strings
Browse files Browse the repository at this point in the history
  • Loading branch information
pichlermarc authored Apr 18, 2024
2 parents dd71376 + d5e0d65 commit 0a746d2
Show file tree
Hide file tree
Showing 19 changed files with 41 additions and 1,117 deletions.
5 changes: 0 additions & 5 deletions .github/component-label-map.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ pkg:instrumentation-aws-lambda:
- changed-files:
- any-glob-to-any-file:
- plugins/node/opentelemetry-instrumentation-aws-lambda/**
- propagators/opentelemetry-propagator-aws-xray/**
pkg:instrumentation-aws-sdk:
- changed-files:
- any-glob-to-any-file:
Expand Down Expand Up @@ -246,10 +245,6 @@ pkg:propagation-utils:
- any-glob-to-any-file:
- packages/opentelemetry-propagation-utils/**
- packages/opentelemetry-test-utils/**
pkg:propagator-aws-xray:
- changed-files:
- any-glob-to-any-file:
- propagators/opentelemetry-propagator-aws-xray/**
pkg:propagator-grpc-census-binary:
- changed-files:
- any-glob-to-any-file:
Expand Down
2 changes: 0 additions & 2 deletions .github/component_owners.yml
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,6 @@ components:
- obecny
plugins/web/opentelemetry-plugin-react-load:
- martinkuba
propagators/opentelemetry-propagator-aws-xray:
- carolabadeer
propagators/opentelemetry-propagator-grpc-census-binary: []
# Unmaintained?
propagators/opentelemetry-propagator-instana:
Expand Down
1 change: 0 additions & 1 deletion .release-please-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
"plugins/web/opentelemetry-instrumentation-long-task": "0.37.0",
"plugins/web/opentelemetry-instrumentation-user-interaction": "0.37.0",
"plugins/web/opentelemetry-plugin-react-load": "0.30.0",
"propagators/opentelemetry-propagator-aws-xray": "1.3.1",
"propagators/opentelemetry-propagator-grpc-census-binary": "0.27.1",
"propagators/opentelemetry-propagator-instana": "0.3.1",
"propagators/opentelemetry-propagator-ot-trace": "0.27.1"
Expand Down
86 changes: 16 additions & 70 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 25 additions & 5 deletions plugins/node/instrumentation-undici/test/undici.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@ describe('UndiciInstrumentation `undici` tests', function () {
propagation.disable();
mockServer.mockListener(undefined);
mockServer.stop(done);

// Close kept-alive sockets. This can save a 4s keep-alive delay before the
// process exits.
(undici as any).getGlobalDispatcher().close();
});

beforeEach(function () {
Expand Down Expand Up @@ -216,11 +220,27 @@ describe('UndiciInstrumentation `undici` tests', function () {
};

const queryRequestUrl = `${protocol}://${hostname}:${mockServer.port}/?query=test`;
const firstQueryResponse = await undici.request(queryRequestUrl, {
headers,
// @ts-expect-error - method type expects in uppercase
method: 'get',
});
let firstQueryResponse;
try {
firstQueryResponse = await undici.request(queryRequestUrl, {
headers,
// @ts-expect-error - method type expects in uppercase
method: 'get',
});
} catch (err: any) {
// This request is using a bogus HTTP method `get`. If (a) using Node.js
// v14, v16, or early v18.x versions and (b) this request is re-using
// a socket (from an earlier keep-alive request in this test file),
// then Node.js will emit 'end' on the socket. Undici then throws
// `SocketError: other side closed`. Given this is only for old Node.js
// versions and for this rare case of using a bogus HTTP method, we will
// skip out of this test instead of attempting to fully understand it.
assert.strictEqual(err.message, 'other side closed');
this.skip();
}
if (!firstQueryResponse) {
return;
}
await consumeResponseBody(firstQueryResponse.body);

const secondQueryResponse = await undici.request(queryRequestUrl, {
Expand Down

This file was deleted.

9 changes: 0 additions & 9 deletions propagators/opentelemetry-propagator-aws-xray/.eslintrc.js

This file was deleted.

62 changes: 0 additions & 62 deletions propagators/opentelemetry-propagator-aws-xray/CHANGELOG.md

This file was deleted.

Loading

0 comments on commit 0a746d2

Please sign in to comment.