Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

fix: set delegate after successful registration #105

Merged
merged 4 commits into from
Jul 27, 2021
Merged

fix: set delegate after successful registration #105

merged 4 commits into from
Jul 27, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Jul 16, 2021

Set the new TracerProvider as delegate in ProxyTracerProvider only if global registration was successful.

fixes: #104

Set the new TracerProvider as delegate in ProxyTracerProvider
only if global registration was successful.
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #105 (82142be) into main (7ca5a00) will increase coverage by 0.19%.
The diff coverage is 100.00%.

❗ Current head 82142be differs from pull request most recent head a7c96b0. Consider uploading reports for the commit a7c96b0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   94.90%   95.09%   +0.19%     
==========================================
  Files          42       42              
  Lines         569      571       +2     
  Branches       89       90       +1     
==========================================
+ Hits          540      543       +3     
+ Misses         29       28       -1     
Impacted Files Coverage Δ
src/api/trace.ts 100.00% <100.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca5a00...a7c96b0. Read the comment docs.

@Flarna Flarna added the bug Something isn't working label Jul 21, 2021
@Flarna Flarna requested a review from MSNev as a code owner July 26, 2021 17:58
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obecny obecny merged commit 071d33e into open-telemetry:main Jul 27, 2021
@Flarna Flarna deleted the set-provider branch July 27, 2021 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setGlobalTracerProvider sets delegate in ProxyTracer even if set global fails
6 participants