chore: make startActiveSpan required in the tracer interface

Signed-off-by: naseemkullah <naseem@transit.app>
open-telemetry · May 12, 2021 · 56f11e2 · 56f11e2
1 parent b53dd2f
commit 56f11e2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/src/trace/ProxyTracer.ts b/src/trace/ProxyTracer.ts
@@ -38,15 +38,9 @@ export class ProxyTracer implements Tracer {
     return this._getTracer().startSpan(name, options, context);
   }
 
-  startActiveSpan?<F extends (span: Span) => ReturnType<F>>():
-    | ReturnType<F>
-    | undefined {
+  startActiveSpan<F extends (span: Span) => ReturnType<F>>(): ReturnType<F> {
     const tracer = this._getTracer();
-
-    if (tracer.startActiveSpan) {
-      return Reflect.apply(tracer.startActiveSpan, tracer, arguments);
-    }
-    return;
+    return Reflect.apply(tracer.startActiveSpan, tracer, arguments);
   }
 
   /**

diff --git a/src/trace/tracer.ts b/src/trace/tracer.ts
@@ -78,16 +78,16 @@ export interface Tracer {
    *   do some more work
    *   span.end();
    */
-  startActiveSpan?<F extends (span: Span) => ReturnType<F>>(
+  startActiveSpan<F extends (span: Span) => ReturnType<F>>(
     name: string,
     fn: F
   ): ReturnType<F>;
-  startActiveSpan?<F extends (span: Span) => ReturnType<F>>(
+  startActiveSpan<F extends (span: Span) => ReturnType<F>>(
     name: string,
     options: SpanOptions,
     fn: F
   ): ReturnType<F>;
-  startActiveSpan?<F extends (span: Span) => ReturnType<F>>(
+  startActiveSpan<F extends (span: Span) => ReturnType<F>>(
     name: string,
     options: SpanOptions,
     context: Context,