-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency io.zipkin.reporter2:zipkin-reporter-bom to v3.4.2 #6704
Update dependency io.zipkin.reporter2:zipkin-reporter-bom to v3.4.2 #6704
Conversation
not sure how going from 3.4.0 -> 3.4.1 would cause this much failure. @codefromthecrypt any ideas what's up here? |
I saw some failures due to issues finding the zipkin artifacts. I wonder if the PR was created before the artifacts were fully synchronized to maven. Rerunning to see if things work with some additional time having passed. |
@shakuzen noticed that there was a maven outage during the release, and that this went through the next attempt. Possibly we are auditing something here that didn't affect folks not linting maven? Would cutting a 3.4.2 help? |
I just pushed another tag on zipkin-reporter-java repo to re-release the same code (there are limitations on "fixing central" which leaves us only this option really). cc @shakuzen @reta @anuraaga @making for visibility (currently active collaborators of zipkin) about the redundant release $ git tag release-3.4.2
$ git push origin release-3.4.2
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To https://github.com/openzipkin/zipkin-reporter-java.git
* [new tag] release-3.4.2 -> release-3.4.2 |
here's the action which when done and after maven sync delay should be a-ok again https://github.com/openzipkin/zipkin-reporter-java/actions/runs/10933760571 |
a7fc833
to
4c0b0d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6704 +/- ##
=========================================
Coverage 90.05% 90.05%
Complexity 6457 6457
=========================================
Files 718 718
Lines 19511 19511
Branches 1922 1922
=========================================
Hits 17571 17571
Misses 1350 1350
Partials 590 590 ☔ View full report in Codecov by Sentry. |
Thanks a lot @codefromthecrypt ! |
This PR contains the following updates:
3.4.0
->3.4.2
Release Notes
openzipkin/zipkin-reporter-java (io.zipkin.reporter2:zipkin-reporter-bom)
v3.4.2
Compare Source
v3.4.1
: Zipkin Reporter 3.4Compare Source
Zipkin Reporter 3.4 deprecates
AsyncReporter/SpanHandler
queuedMaxBytes
and disables it by default.When introduced,
AsyncReporter
had three ways to trigger a queue flush:queuedMaxSpans
- when the number of spans in the queue exceeds a thresholdqueuedMaxBytes
- when the size of the spans in the queue exceeds a thresholdmessageTimeout
- when a span has been in the queue longer than a thresholdqueuedMaxBytes
was deprecated because requires time in the critical path, to calculate the size of a span to make sure it doesn't breach the threshold. This is problematic in tools that check for pinning, like Virtual Threads.Thanks a lot to @reta for sorting this out!
Full Changelog: https://github.com/openzipkin/zipkin-reporter-java/compare/3.3.0..3.4.1
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.