Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency io.netty:netty-bom to v4.1.101.Final #5970

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 9, 2023

Mend Renovate logo banner

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
io.netty:netty-bom (source) 4.1.100.Final -> 4.1.101.Final age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team November 9, 2023 14:49
@breedx-splk
Copy link
Contributor

Build failure:

JaegerRemoteSamplerGrpcNettyTest > pollingInterval_duration() FAILED
    java.lang.AssertionError: [Extracted: root] 
    Expecting actual:
      TraceIdRatioBased{0.001000}
    to be an instance of:
      io.opentelemetry.sdk.extension.trace.jaeger.sampler.RateLimitingSampler
    but was instance of:
      io.opentelemetry.sdk.trace.samplers.TraceIdRatioBasedSampler
        at io.opentelemetry.sdk.extension.trace.jaeger.sampler.JaegerRemoteSamplerGrpcNettyTest.lambda$samplerIsType$4(JaegerRemoteSamplerGrpcNettyTest.java:323)

weird that the sampler implementation changed..... ❓

@renovate renovate bot force-pushed the renovate/netty-monorepo branch from 585b4eb to 020b04a Compare November 20, 2023 21:36
@jack-berg
Copy link
Member

Looks like this is failing because of a known issue in grpc-java: grpc/grpc-java#10665

Will need to wait for a patch to the grpc bom before upgrading netty bom.

@renovate renovate bot force-pushed the renovate/netty-monorepo branch from 020b04a to dc58b2c Compare November 28, 2023 15:42
@jack-berg
Copy link
Member

Rebasing and re-building after #6021 was merged. 🤞

@renovate renovate bot force-pushed the renovate/netty-monorepo branch from dc58b2c to 1954482 Compare November 28, 2023 15:46
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da2cc9f) 91.16% compared to head (1954482) 91.18%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5970      +/-   ##
============================================
+ Coverage     91.16%   91.18%   +0.01%     
- Complexity     5613     5614       +1     
============================================
  Files           616      616              
  Lines         16564    16564              
  Branches       1642     1642              
============================================
+ Hits          15101    15104       +3     
+ Misses         1013     1012       -1     
+ Partials        450      448       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit a7b2cc0 into main Nov 28, 2023
17 checks passed
@jack-berg jack-berg deleted the renovate/netty-monorepo branch November 28, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants