Change processedSpans&processedLogs labels #5631
Conversation
b006926 to
d9461d9
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5631 +/- ##
============================================
- Coverage 91.32% 91.31% -0.01%
+ Complexity 4979 4978 -1
============================================
Files 554 554
Lines 14731 14739 +8
Branches 1376 1376
============================================
+ Hits 13453 13459 +6
Misses 884 884
- Partials 394 396 +2
☔ View full report in Codecov by Sentry. |
|
@jkwatson @jack-berg PTAL |
|
This removes an existing attribute, correct? I'm worried it will break existing dashboards if we get rid of an attribute. @jack-berg is there a spec for these metrics yet? |
|
this modification is incompatible。 If you think compatibility is necessary, I can keep the original label and then add new labels |
| @@ -45,8 +49,8 @@ public final class BatchLogRecordProcessor implements LogRecordProcessor { | |||
| BatchLogRecordProcessor.class.getSimpleName() + "_WorkerThread"; | |||
| private static final AttributeKey<String> LOG_RECORD_PROCESSOR_TYPE_LABEL = | |||
| AttributeKey.stringKey("logRecordProcessorType"); | |||
| private static final AttributeKey<Boolean> LOG_RECORD_PROCESSOR_DROPPED_LABEL = | |||
| AttributeKey.booleanKey("dropped"); | |||
| private static final AttributeKey<String> LOG_RECORD_PROCESS_STATUS_LABEL = | |||
There was a problem hiding this comment.
Strongly recommend avoiding using the term "label" to refer to OpenTelemetry attributes. Let's try and be consistent in our naming. 🙏🏻
|
This is being actively discussed in open-telemetry/semantic-conventions#184. In order to reduce churn, I'm inclined to hold any changes to these metrics until a new set of experimental semantic conventions lands. @JoeCqupt would you be able to comment over on that PR with your use case / requirements? |
when i use BatchLogRecordProcessor/BatchSpanProcessor.
i want to know dropped ratio and exported success ratio and exported fail ratio and etc. but exist metrics can not compute those.
i want achieve this goal by updating processedSpans&processedLogs labels .
dropped ratio:
dropped/processedexported success ratio:
exported/(processed - dropped)exported fail ratio:
1 - exported/(processed - dropped)