Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented the Jaeger Span Exporter using gRPC as the transport #481
Implemented the Jaeger Span Exporter using gRPC as the transport #481
Changes from all commits
0ad05b1
634af39
a88de86
824bc25
64bea08
d9f9571
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be SDK as provided dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean
implementation
instead ofprovided
? I think it's appropriate to haveapi
here, as methods from this module accept and return instances of classes defined by the SDK module.https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_recognizing_dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is
api
translated to maven dependency type? Is itcompile
orprovided
? I thought it isprovided
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The differences in Gradle are mostly about what is exported to consumers of the library: an application declaring a dependency on the
exporters/jaeger
module will haveopentelemetry-sdk
as a transitive dependency, as it's declared asapi
. The dependencies thatexporters/jaeger
declare asimplementation
aren't transitive dependencies for a consumer.There's a
runtimeOnly
mode as well, which is probably close to whatprovided
does in Maven. But still, I don't think it's the right mode.api
still seems the most appropriate here.