Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prototype] Move Context interaction to Tracer #1753

Closed
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update name.
  • Loading branch information
carlosalberto committed Oct 4, 2020
commit aeec7649d35688e1eb1b29e952cf1bbf4333930e
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ private static List<Context> createContexts(List<SpanContext> spanContexts) {
List<Context> contexts = new ArrayList<>();
for (SpanContext context : spanContexts) {
contexts.add(
OpenTelemetry.getTracer().setCurrentSpan(DefaultSpan.create(context), Context.ROOT));
OpenTelemetry.getTracer().contextWithSpan(DefaultSpan.create(context), Context.ROOT));
}
return contexts;
}
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/io/opentelemetry/trace/Tracer.java
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ default Span getCurrentSpan(Context context) {
}

/** Sets the Span for the specified Context. */
default Context setCurrentSpan(Span span, Context context) {
default Context contextWithSpan(Span span, Context context) {
return TracingContextUtils.withSpan(span, context);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public <C> void inject(Context context, C carrier, Setter<C> setter) {
return context;
}

return OpenTelemetry.getTracer().setCurrentSpan(DefaultSpan.create(spanContext), context);
return OpenTelemetry.getTracer().contextWithSpan(DefaultSpan.create(spanContext), context);
}

private static <C> SpanContext extractImpl(C carrier, Getter<C> getter) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ private static SpanContext getSpanContext(Context context) {
}

private static Context withSpanContext(SpanContext spanContext, Context context) {
return OpenTelemetry.getTracer().setCurrentSpan(DefaultSpan.create(spanContext), context);
return OpenTelemetry.getTracer().contextWithSpan(DefaultSpan.create(spanContext), context);
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public abstract static class AbstractContextInjectBenchmark {
public Map<String, String> measureInject() {
Context context =
OpenTelemetry.getTracer()
.setCurrentSpan(DefaultSpan.create(contextToTest), Context.current());
.contextWithSpan(DefaultSpan.create(contextToTest), Context.current());
doInject(context, carrier);
return carrier;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public <C> Context extract(Context context, C carrier, Getter<C> getter) {
return context;
}

return OpenTelemetry.getTracer().setCurrentSpan(DefaultSpan.create(spanContext), context);
return OpenTelemetry.getTracer().contextWithSpan(DefaultSpan.create(spanContext), context);
}

private static <C> SpanContext getSpanContextFromHeader(C carrier, Getter<C> getter) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public <C> Context extract(Context context, C carrier, TextMapPropagator.Getter<
return context;
}

return OpenTelemetry.getTracer().setCurrentSpan(DefaultSpan.create(spanContext), context);
return OpenTelemetry.getTracer().contextWithSpan(DefaultSpan.create(spanContext), context);
}

private static <C> SpanContext getSpanContextFromMultipleHeaders(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public <C> Context extract(Context context, C carrier, TextMapPropagator.Getter<
return context;
}

return OpenTelemetry.getTracer().setCurrentSpan(DefaultSpan.create(spanContext), context);
return OpenTelemetry.getTracer().contextWithSpan(DefaultSpan.create(spanContext), context);
}

@SuppressWarnings("StringSplitter")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public <C> Context extract(Context context, C carrier, Getter<C> getter) {
return context;
}

return OpenTelemetry.getTracer().setCurrentSpan(DefaultSpan.create(spanContext), context);
return OpenTelemetry.getTracer().contextWithSpan(DefaultSpan.create(spanContext), context);
}

@SuppressWarnings("StringSplitter")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public <C> Context extract(Context context, C carrier, Getter<C> getter) {
if (!spanContext.isValid()) {
return context;
}
return OpenTelemetry.getTracer().setCurrentSpan(DefaultSpan.create(spanContext), context);
return OpenTelemetry.getTracer().contextWithSpan(DefaultSpan.create(spanContext), context);
}

static SpanContext buildSpanContext(String traceId, String spanId, String sampled) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ void extract_InvalidFlags_NonNumeric() {
}

private static Context withSpanContext(SpanContext spanContext, Context context) {
return OpenTelemetry.getTracer().setCurrentSpan(DefaultSpan.create(spanContext), context);
return OpenTelemetry.getTracer().contextWithSpan(DefaultSpan.create(spanContext), context);
}

private static SpanContext getSpanContext(Context context) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ private static SpanContext getSpanContext(Context context) {
}

private static Context withSpanContext(SpanContext spanContext, Context context) {
return OpenTelemetry.getTracer().setCurrentSpan(DefaultSpan.create(spanContext), context);
return OpenTelemetry.getTracer().contextWithSpan(DefaultSpan.create(spanContext), context);
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ private static SpanContext getSpanContext(Context context) {
}

private static Context withSpanContext(SpanContext spanContext, Context context) {
return OpenTelemetry.getTracer().setCurrentSpan(DefaultSpan.create(spanContext), context);
return OpenTelemetry.getTracer().contextWithSpan(DefaultSpan.create(spanContext), context);
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ private static SpanContext getSpanContext(Context context) {
}

private static Context withSpanContext(SpanContext spanContext, Context context) {
return OpenTelemetry.getTracer().setCurrentSpan(DefaultSpan.create(spanContext), context);
return OpenTelemetry.getTracer().contextWithSpan(DefaultSpan.create(spanContext), context);
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ private static Span getSpan(Context context) {
}

private static Context withSpan(Span span, Context context) {
return OpenTelemetry.getTracer().setCurrentSpan(span, context);
return OpenTelemetry.getTracer().contextWithSpan(span, context);
}

@BeforeEach
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ private RunnableInSpan(Span span, Runnable runnable, boolean endSpan) {
@Override
public void run() {
Context origContext =
OpenTelemetry.getTracer().setCurrentSpan(span, Context.current()).attach();
OpenTelemetry.getTracer().contextWithSpan(span, Context.current()).attach();
try {
runnable.run();
} catch (Throwable t) {
Expand Down Expand Up @@ -89,7 +89,7 @@ private CallableInSpan(Span span, Callable<V> callable, boolean endSpan) {
@Override
public V call() throws Exception {
Context origContext =
OpenTelemetry.getTracer().setCurrentSpan(span, Context.current()).attach();
OpenTelemetry.getTracer().contextWithSpan(span, Context.current()).attach();
try {
return callable.call();
} catch (Exception e) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public String get(HttpServletRequest carrier, String key) {
.setParent(context)
.startSpan();

Context withSpanContext = OpenTelemetry.getTracer().setCurrentSpan(span, context);
Context withSpanContext = OpenTelemetry.getTracer().contextWithSpan(span, context);

// Make a new request using the builder
okhttp3.Request.Builder reqBuilder = new okhttp3.Request.Builder();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ final class Propagation extends BaseShimObject {
public void injectTextMap(SpanContextShim contextShim, TextMapInject carrier) {
Context context =
OpenTelemetry.getTracer()
.setCurrentSpan(DefaultSpan.create(contextShim.getSpanContext()), Context.current());
.contextWithSpan(DefaultSpan.create(contextShim.getSpanContext()), Context.current());
context = BaggageUtils.withBaggage(contextShim.getBaggage(), context);

propagators().getTextMapPropagator().inject(context, carrier, TextMapSetter.INSTANCE);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,13 +185,13 @@ public Span start() {
builder.setNoParent();
} else if (parentSpan != null) {
builder.setParent(
OpenTelemetry.getTracer().setCurrentSpan(parentSpan.getSpan(), Context.ROOT));
OpenTelemetry.getTracer().contextWithSpan(parentSpan.getSpan(), Context.ROOT));
SpanContextShim contextShim = spanContextTable().get(parentSpan);
distContext = contextShim == null ? null : contextShim.getBaggage();
} else if (parentSpanContext != null) {
builder.setParent(
OpenTelemetry.getTracer()
.setCurrentSpan(
.contextWithSpan(
DefaultSpan.create(parentSpanContext.getSpanContext()), Context.ROOT));
distContext = parentSpanContext.getBaggage();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ void noParent_override() {
tracerSdk
.spanBuilder(SPAN_NAME)
.setNoParent()
.setParent(OpenTelemetry.getTracer().setCurrentSpan(parent, Context.current()))
.setParent(OpenTelemetry.getTracer().contextWithSpan(parent, Context.current()))
.startSpan();
try {
assertThat(span.getContext().getTraceIdAsHexString())
Expand All @@ -598,7 +598,7 @@ void noParent_override() {
tracerSdk
.spanBuilder(SPAN_NAME)
.setNoParent()
.setParent(OpenTelemetry.getTracer().setCurrentSpan(parent, Context.current()))
.setParent(OpenTelemetry.getTracer().contextWithSpan(parent, Context.current()))
.startSpan();
try {
assertThat(span2.getContext().getTraceIdAsHexString())
Expand All @@ -624,7 +624,7 @@ void overrideNoParent_remoteParent() {
tracerSdk
.spanBuilder(SPAN_NAME)
.setNoParent()
.setParent(OpenTelemetry.getTracer().setCurrentSpan(parent, Context.current()))
.setParent(OpenTelemetry.getTracer().contextWithSpan(parent, Context.current()))
.startSpan();
try {
assertThat(span.getContext().getTraceIdAsHexString())
Expand All @@ -642,7 +642,7 @@ void overrideNoParent_remoteParent() {
@Test
void parent_fromContext() {
Span parent = tracerSdk.spanBuilder(SPAN_NAME).startSpan();
Context context = OpenTelemetry.getTracer().setCurrentSpan(parent, Context.current());
Context context = OpenTelemetry.getTracer().contextWithSpan(parent, Context.current());
try {
RecordEventsReadableSpan span =
(RecordEventsReadableSpan)
Expand Down Expand Up @@ -712,7 +712,7 @@ void parent_invalidContext() {
(RecordEventsReadableSpan)
tracerSdk
.spanBuilder(SPAN_NAME)
.setParent(OpenTelemetry.getTracer().setCurrentSpan(parent, Context.current()))
.setParent(OpenTelemetry.getTracer().contextWithSpan(parent, Context.current()))
.startSpan();
try {
assertThat(span.getContext().getTraceIdAsHexString())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ void defaultSpanBuilder() {
void getCurrentSpan() {
assertThat(tracer.getCurrentSpan()).isInstanceOf(DefaultSpan.class);
Context origContext =
OpenTelemetry.getTracer().setCurrentSpan(span, Context.current()).attach();
OpenTelemetry.getTracer().contextWithSpan(span, Context.current()).attach();
// Make sure context is detached even if test fails.
try {
assertThat(tracer.getCurrentSpan()).isSameAs(span);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ void bad_solution_to_set_parent() throws Exception {
client =
new Client(
new RequestHandler(
tracer, OpenTelemetry.getTracer().setCurrentSpan(parentSpan, Context.current())));
tracer,
OpenTelemetry.getTracer().contextWithSpan(parentSpan, Context.current())));
String response = client.send("correct_parent").get(15, TimeUnit.SECONDS);
assertThat(response).isEqualTo("correct_parent:response");
} finally {
Expand Down