Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CorrelationContext entry keys and values to simple Strings #1363

Merged
merged 2 commits into from
Jun 22, 2020

Conversation

jkwatson
Copy link
Contributor

Resolves #1334

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #1363 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1363      +/-   ##
============================================
- Coverage     86.89%   86.86%   -0.03%     
+ Complexity     1245     1241       -4     
============================================
  Files           159      157       -2     
  Lines          4791     4788       -3     
  Branches        431      432       +1     
============================================
- Hits           4163     4159       -4     
- Misses          467      468       +1     
  Partials        161      161              
Impacted Files Coverage Δ Complexity Δ
...ationcontext/DefaultCorrelationContextManager.java 56.25% <ø> (ø) 6.00 <0.00> (ø)
...ry/correlationcontext/EmptyCorrelationContext.java 75.00% <ø> (ø) 3.00 <0.00> (ø)
...ava/io/opentelemetry/correlationcontext/Entry.java 100.00% <100.00%> (ø) 10.00 <8.00> (+7.00)
...opentelemetry/opentracingshim/SpanContextShim.java 88.88% <100.00%> (+2.40%) 10.00 <1.00> (ø)
.../sdk/correlationcontext/CorrelationContextSdk.java 92.15% <100.00%> (ø) 15.00 <7.00> (ø)
...telemetry/sdk/trace/export/BatchSpanProcessor.java 94.59% <0.00%> (-1.36%) 8.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2074b4d...b9251fd. Read the comment docs.

@carlosalberto
Copy link
Contributor

Pretty sweet change, LGTM.

@carlosalberto
Copy link
Contributor

Ping @bogdandrutu

@bogdandrutu bogdandrutu merged commit 24b4be9 into open-telemetry:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can CorrelationContext EntryKey/EntryValue be just Strings?
3 participants