Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Jaeger exporter to map Resources to process tags #1609

Closed
jkwatson opened this issue Sep 1, 2020 · 5 comments · Fixed by #1800
Closed

Update Jaeger exporter to map Resources to process tags #1609

jkwatson opened this issue Sep 1, 2020 · 5 comments · Fixed by #1800
Labels
help wanted priority:p2 Medium priority issues and bugs. release:required-for-ga Required for 1.0 GA release

Comments

@jkwatson
Copy link
Contributor

jkwatson commented Sep 1, 2020

See https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk_exporters/jaeger.md#resource
@jkwatson jkwatson added help wanted release:required-for-ga Required for 1.0 GA release priority:p2 Medium priority issues and bugs. labels Sep 1, 2020
@malafeev
Copy link
Contributor

malafeev commented Sep 8, 2020

something like:

target.addAllTags(toKeyValues(span.getResource().getAttributes()));

?
where target is: Model.Span.Builder (https://github.com/open-telemetry/opentelemetry-java/blob/master/exporters/jaeger/src/main/java/io/opentelemetry/exporters/jaeger/Adapter.java#L74)

@jkwatson
Copy link
Contributor Author

jkwatson commented Sep 8, 2020

Not sure if there might also need to be some naming tweaks along the way...

@malafeev
Copy link
Contributor

malafeev commented Sep 9, 2020

yes, so question about names... How to tweak them if needed?

@jkwatson
Copy link
Contributor Author

jkwatson commented Sep 9, 2020

Probably have to look for certain keys (from the spec) and rename them while writing them into the Model.Span.Builder. I'm not sure if there's a better way.

@jkwatson jkwatson mentioned this issue Sep 14, 2020
Closed
@jkwatson
Copy link
Contributor Author

@malafeev Rereading the spec, it looks like the resource attributes just get mapped over directly. I was thinking of instrumentation library attributes.

malafeev pushed a commit to malafeev/opentelemetry-java that referenced this issue Oct 14, 2020
open-telemetry#1609 Update Jaeger exporter to map Resources to proces…
8cdbcfe 
…s tags

Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
@malafeev malafeev mentioned this issue Oct 14, 2020
Merged
anuraaga pushed a commit that referenced this issue Oct 21, 2020
Update Jaeger exporter to map Resources to process tags (#1800)
17ef49a 
* #1609 Update Jaeger exporter to map Resources to process tags

Signed-off-by: Sergei Malafeev <sergei@malafeev.org>

* add resource attributes to process tags

Signed-off-by: Sergei Malafeev <sergei@malafeev.org>

* fix checkstyle error

Signed-off-by: Sergei Malafeev <sergei@malafeev.org>

* refactored according to review comments

Signed-off-by: Sergei Malafeev <sergei@malafeev.org>

* implement comments

Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted priority:p2 Medium priority issues and bugs. release:required-for-ga Required for 1.0 GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Jaeger exporter to map Resources to process tags malafeev/opentelemetry-java
2 participants
@jkwatson @malafeev