Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.12.x branch] Fix possible deadlock #5601

Merged
merged 1 commit into from
Mar 17, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -117,34 +117,11 @@ public AgentClassLoader(File javaagentFile, String internalJarFileName) {

private static ClassLoader getParentClassLoader() {
if (JAVA_VERSION > 8) {
ClassLoader platformClassLoader = getPlatformLoader();
return new ClassLoader(null) {
@Override
protected Class<?> loadClass(String name, boolean resolve) throws ClassNotFoundException {
// prometheus exporter uses jdk http server, load it from the platform class loader
if (name != null && name.startsWith("com.sun.net.httpserver.")) {
return platformClassLoader.loadClass(name);
}
return super.loadClass(name, resolve);
}
};
return new JdkHttpServerClassLoader();
}
return null;
}

private static ClassLoader getPlatformLoader() {
/*
Must invoke ClassLoader.getPlatformClassLoader by reflection to remain
compatible with java 8.
*/
try {
Method method = ClassLoader.class.getDeclaredMethod("getPlatformClassLoader");
return (ClassLoader) method.invoke(null);
} catch (InvocationTargetException | NoSuchMethodException | IllegalAccessException exception) {
throw new IllegalStateException(exception);
}
}

private static int getJavaVersion() {
String javaSpecVersion = System.getProperty("java.specification.version");
if ("1.8".equals(javaSpecVersion)) {
Expand Down Expand Up @@ -451,4 +428,44 @@ public long getContentLengthLong() {
return -1;
}
}

private static class JdkHttpServerClassLoader extends ClassLoader {

static {
// this class loader doesn't load any classes, so this is technically unnecessary,
// but included for safety, just in case we every change Class.forName() below back to
// super.loadClass()
registerAsParallelCapable();
}

private final ClassLoader platformClassLoader = getPlatformLoader();

public JdkHttpServerClassLoader() {
super(null);
}

@Override
protected Class<?> loadClass(String name, boolean resolve) throws ClassNotFoundException {
// prometheus exporter uses jdk http server, load it from the platform class loader
if (name != null && name.startsWith("com.sun.net.httpserver.")) {
return platformClassLoader.loadClass(name);
}
return Class.forName(name, false, null);
}

private static ClassLoader getPlatformLoader() {
/*
Must invoke ClassLoader.getPlatformClassLoader by reflection to remain
compatible with java 8.
*/
try {
Method method = ClassLoader.class.getDeclaredMethod("getPlatformClassLoader");
return (ClassLoader) method.invoke(null);
} catch (InvocationTargetException
| NoSuchMethodException
| IllegalAccessException exception) {
throw new IllegalStateException(exception);
}
}
}
}