Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't block snapshot publishing on testLatestDeps #4684

Merged
merged 1 commit into from
Nov 21, 2021
Merged

Don't block snapshot publishing on testLatestDeps #4684

merged 1 commit into from
Nov 21, 2021

Conversation

trask
Copy link
Member

@trask trask commented Nov 21, 2021

main is not in a great spot right now because there hasn't been a successful CI build since I bumped the version to 1.9.0-SNAPSHOT in #4675, which means there hasn't been a snapshot published for 1.9.0-SNAPSHOT, which means the example extension and distro won't build outside of CI (in CI we build the snapshots locally and use --init-script ../../.github/scripts/local.init.gradle.kts).

The reason there hasn't been a successful CI is because of a few testLatestDeps problems #4676, #4679, #4682.

But really it seems better for testLatestDeps to not block snapshot publishing (it already doesn't block releases).

@iNikem
Copy link
Contributor

iNikem commented Nov 21, 2021

It seems more and more that we don't actually care that much about latest deps. Or at least we don't want to be responsible for fixing them ASAP, more like "whenever we have time for that".

@trask
Copy link
Member Author

trask commented Nov 21, 2021

It seems more and more that we don't actually care that much about latest deps. Or at least we don't want to be responsible for fixing them ASAP, more like "whenever we have time for that".

This is a good topic, I opened #4688 to discuss further.

@trask
Copy link
Member Author

trask commented Nov 21, 2021

Going ahead and merging since we still need a 1.9.0-SNAPSHOT.

We still open an issue on testLatestDeps failure. This PR just publishes SNAPSHOT anyways so that we don't block other activity (e.g. testing a SNAPSHOT, or in the current case publishing the first SNAPSHOT release for a particular version so that examples build locally).

@trask trask merged commit a9928b5 into open-telemetry:main Nov 21, 2021
@trask trask deleted the snapshot-publishing branch November 21, 2021 22:49
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants