Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow only one propagator per concern #451

Merged
merged 2 commits into from
May 28, 2020
Merged

allow only one propagator per concern #451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46aed88
#425 allow only one propagator per concern
malafeev May 28, 2020
fbd69c8
Merge branch 'master' into propagators
trask May 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions agent-tooling/src/main/java/io/opentelemetry/auto/tooling/PropagatorsInitializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,18 @@ public static void initializePropagators(List<String> propagators) {

DefaultContextPropagators.Builder propagatorsBuilder = DefaultContextPropagators.builder();

boolean addedPropagator = false;
for (String propagatorId : propagators) {
HttpTextFormat textPropagator = TEXTMAP_PROPAGATORS.get(propagatorId.trim().toLowerCase());
if (textPropagator != null) {
if (addedPropagator) {
log.warn(
"Only one propagator per concern can be added, " + textPropagator + " is ignored");
continue;
}
propagatorsBuilder.addHttpTextFormat(textPropagator);
log.info("Added " + textPropagator + " propagator");
addedPropagator = true;
} else {
log.warn("No matching propagator for " + propagatorId);
}
Expand Down