Correctly use muzzleTooling configuration to allow for external additions #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/easycla |
anuraaga
approved these changes
Aug 2, 2021
| @@ -34,11 +34,11 @@ val RANGE_COUNT_LIMIT = 10 | |||
|
|
|||
| val muzzleConfig = extensions.create<MuzzleExtension>("muzzle") | |||
|
|
|||
| val muzzleTooling by configurations.creating { | |||
| val muzzleTooling: Configuration by configurations.creating { | |||
There was a problem hiding this comment.
We generally wouldn't specify the type for this sort of DSL usage, is it needed?
There was a problem hiding this comment.
IDEA complained that it does not understand if this is nullable type or not.
|
/easycla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged and published before main project can drop its old plugin definition